fix(ui): Prevent versionId 0 Error on New Applications with No History #20574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashakostohrys <pavel@codefresh.io>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
pasha-codefresh
added a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Oct 31, 2024
…o History (argoproj#20574)" This reverts commit 33ecbbc.
pasha-codefresh
added a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Oct 31, 2024
…s with No History (argoproj#20574)"" This reverts commit cecf8f4.
pasha-codefresh
added a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Oct 31, 2024
…s with No History (argoproj#20574)"" This reverts commit cecf8f4.
pasha-codefresh
added a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Oct 31, 2024
…s with No History (argoproj#20574)"" This reverts commit cecf8f4.
ishitasequeira
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Revert "fix(ui): Prevent versionId 0 Error on New Applications with No History (#20574)" This reverts commit 33ecbbc. * feat: add prompting to confirm app resource deletion Signed-off-by: pashakostohrys <pavel@codefresh.io> * Revert "Revert "fix(ui): Prevent versionId 0 Error on New Applications with No History (#20574)"" This reverts commit cecf8f4. --------- Signed-off-by: pashakostohrys <pavel@codefresh.io>
ishitasequeira
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Revert "fix(ui): Prevent versionId 0 Error on New Applications with No History (#20574)" This reverts commit 33ecbbc. * feat: add prompting to confirm project deletion Signed-off-by: pashakostohrys <pavel@codefresh.io> * Revert "Revert "fix(ui): Prevent versionId 0 Error on New Applications with No History (#20574)"" This reverts commit cecf8f4. --------- Signed-off-by: pashakostohrys <pavel@codefresh.io>
ishitasequeira
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Revert "fix(ui): Prevent versionId 0 Error on New Applications with No History (#20574)" This reverts commit 33ecbbc. * feat: add prompting to confirm project role deletion Signed-off-by: pashakostohrys <pavel@codefresh.io> * Revert "Revert "fix(ui): Prevent versionId 0 Error on New Applications with No History (#20574)"" This reverts commit cecf8f4. * feat: add prompting to confirm project role deletion Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For newly created applications without any history, an error occurs because versionId 0 is not found. This happens because the front-end currently sends a versionId even when there is no historical data available.
Expected Behavior:
The front-end should check for the presence of history before sending a versionId. If no history exists, it should avoid sending a versionId, ensuring no error appears on the UI.
Steps to Reproduce: