Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automate Triggering of trigger-release.sh After Init Release GitHub Action #20323 #20560

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jaehanbyun
Copy link
Contributor

@jaehanbyun jaehanbyun commented Oct 28, 2024

Closes: #20323

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

What I have done:

According to the existing documentation, in Step 2 - Tag Release Branch of the release process, developers are required to manually execute the trigger-release.sh script. This manual step introduces the potential for human error, such as entering the wrong version number or working on the incorrect branch.

To mitigate these risks, I have automated this step by adding a new job called trigger-release to the init-release.yaml workflow. This job automatically executes the trigger-release.sh script after the prepare-release job completes. By doing so, the release process becomes fully automated, eliminating the need for manual script execution and reducing the likelihood of human errors.

@jaehanbyun jaehanbyun requested review from a team as code owners October 28, 2024 12:34
Copy link

bunnyshell bot commented Oct 28, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@@ -74,4 +74,25 @@ jobs:
signoff: true
labels: release

trigger-release:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be executed after init-release PR is merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a new workflow file. PTAL!

@pasha-codefresh
Copy link
Member

Thank you @jaehanbyun for taking it, left small comment

…tHub Action

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@29d5229). Learn more about missing BASE report.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20560   +/-   ##
=========================================
  Coverage          ?   55.12%           
=========================================
  Files             ?      324           
  Lines             ?    55116           
  Branches          ?        0           
=========================================
  Hits              ?    30384           
  Misses            ?    22114           
  Partials          ?     2618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Member

Thank you, from first glance it looks good, lets discuss it on contribution meeting, and probably we will merge it after 2.13 GA release

Also @34fathombelow should review it

Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nit is to update the release docs and mention that Step 2 is now automated.
https://github.com/argoproj/argo-cd/blob/master/docs/developer-guide/releasing.md

Signed-off-by: jaehanbyun <awbrg789@naver.com>
@jaehanbyun jaehanbyun requested a review from a team as a code owner October 30, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate Triggering of trigger-release.sh After "Init Release" GitHub Action
3 participants