Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eAnalogReference from ArduinoCore-samd #718

Closed
wants to merge 1 commit into from
Closed

Remove eAnalogReference from ArduinoCore-samd #718

wants to merge 1 commit into from

Conversation

rubenstar
Copy link

Currently, the header for analogReference(...) is defined in ArduinoCore-API (api/Common.h).

My proposal is to move this enum to ArduinoCore-API and align the naming to the scheme that is used there.

This comes with the additional benefit of fixing a bug where the header that is defined over at ArduinoCore-API takes uint8_t as argument type, which leads to a compilation warning when compiling together with ArduinoCore-samd.

I filed a corresponding PR there too:
arduino/ArduinoCore-API#236

This unfortunately breaks a lot of the sketches as the corresponding change has not yet landed in ArduinoCore-API.

Moved to ArduinoCore-API and renamed to AnalogReference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants