Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFiClient - remove timeouts after startClient fw call #224

Closed
wants to merge 1 commit into from
Closed

WiFiClient - remove timeouts after startClient fw call #224

wants to merge 1 commit into from

Conversation

JAndrassy
Copy link

startClient function is blocking in nina firmware (18 seconds). if it timed out it doesn't make sense to wait additional 10 seconds.

@JAndrassy
WiFiClient - remove timeouts after startClient fw call
9c64c96 
startClient is blocking in firmware.
if it timed out it doesn't make sense to wait additional 10 seconds
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Memory usage change @ 9c64c96

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 💚 -212 - 0 -0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018:mode=on 💚 -344 - 0 -0.71 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 💚 -208 - 0 -0.08 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -208 - 0 -0.08 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 💚 -208 - 0 -0.08 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/AP_SimpleWebServer
flash		 % examples/AP_SimpleWebServer
RAM for global variables		 % examples/ConnectNoEncryption
flash		 % examples/ConnectNoEncryption
RAM for global variables		 % examples/ConnectWithWEP
flash		 % examples/ConnectWithWEP
RAM for global variables		 % examples/ConnectWithWPA
flash		 % examples/ConnectWithWPA
RAM for global variables		 % examples/ConnectWithWPA2Enterprise
flash		 % examples/ConnectWithWPA2Enterprise
RAM for global variables		 % examples/ScanNetworks
flash		 % examples/ScanNetworks
RAM for global variables		 % examples/ScanNetworksAdvanced
flash		 % examples/ScanNetworksAdvanced
RAM for global variables		 % examples/SimpleWebServerWiFi
flash		 % examples/SimpleWebServerWiFi
RAM for global variables		 % examples/Tools/CheckFirmwareVersion
flash		 % examples/Tools/CheckFirmwareVersion
RAM for global variables		 % examples/Tools/FirmwareUpdater
flash		 % examples/Tools/FirmwareUpdater
RAM for global variables		 % examples/Tools/SerialNINAPassthrough
flash		 % examples/Tools/SerialNINAPassthrough
RAM for global variables		 % examples/WiFiChatServer
flash		 % examples/WiFiChatServer
RAM for global variables		 % examples/WiFiPing
flash		 % examples/WiFiPing
RAM for global variables		 % examples/WiFiSSLClient
flash		 % examples/WiFiSSLClient
RAM for global variables		 % examples/WiFiStorage
flash		 % examples/WiFiStorage
RAM for global variables		 % examples/WiFiUdpNtpClient
flash		 % examples/WiFiUdpNtpClient
RAM for global variables		 % examples/WiFiUdpSendReceiveString
flash		 % examples/WiFiUdpSendReceiveString
RAM for global variables		 % examples/WiFiWebClient
flash		 % examples/WiFiWebClient
RAM for global variables		 % examples/WiFiWebClientRepeating
flash		 % examples/WiFiWebClientRepeating
RAM for global variables		 % examples/WiFiWebServer
flash		 % examples/WiFiWebServer
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect -212 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -212 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -212 -0.0 0 0.0 0 0.0 0 0.0 -212 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -212 -0.0 0 0.0 -212 -0.0 0 0.0 -212 -0.0 0 0.0
arduino:megaavr:uno2018:mode=on -344 -0.71 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -344 -0.71 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -344 -0.71 0 0.0 0 0.0 0 0.0 -344 -0.71 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -344 -0.71 0 0.0 -344 -0.71 0 0.0 -344 -0.71 0 0.0
arduino:samd:mkrvidor4000 -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 -208 -0.08 0 0.0 -208 -0.08 0 0.0
arduino:samd:mkrwifi1010 -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 -208 -0.08 0 0.0 -208 -0.08 0 0.0
arduino:samd:nano_33_iot -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -208 -0.08 0 0.0 -208 -0.08 0 0.0 -208 -0.08 0 0.0
Click for full report CSV 
Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,-212,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-212,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-212,-0.0,0,0.0,0,0.0,0,0.0,-212,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-212,-0.0,0,0.0,-212,-0.0,0,0.0,-212,-0.0,0,0.0
arduino:megaavr:uno2018:mode=on,-344,-0.71,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-344,-0.71,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-344,-0.71,0,0.0,0,0.0,0,0.0,-344,-0.71,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-344,-0.71,0,0.0,-344,-0.71,0,0.0,-344,-0.71,0,0.0
arduino:samd:mkrvidor4000,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,-208,-0.08,0,0.0,-208,-0.08,0,0.0
arduino:samd:mkrwifi1010,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,-208,-0.08,0,0.0,-208,-0.08,0,0.0
arduino:samd:nano_33_iot,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-208,-0.08,0,0.0,-208,-0.08,0,0.0,-208,-0.08,0,0.0

@JAndrassy JAndrassy mentioned this pull request Jan 4, 2023
Open
@JAndrassy
Copy link
Author

closing, because it would now create conflict with #252

@JAndrassy JAndrassy closed this Sep 17, 2023
@JAndrassy JAndrassy deleted the remove_superfluous_connect_timeout branch November 6, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAndrassy @per1234