Don't change default baud rate for MKR Vidor 4000 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The esptool expects an initial detection phase where baud rate is 115200. Setting it to 119400 is causing wacky errors like detecting an incorrect crystal frequency: ``` WARNING: Detected crystal freq 38.94MHz is quite different to normalized freq 40MHz. Unsupported crystal in use? Crystal is 40MHz ``` It still works fine with 119400 rate, but it creates a warning and there's no need to distinguish Vidor from the other MKR boards here.
|
See https://github.com/espressif/esptool#baud-rate for why it has to be 115200. |
sameer
changed the title
|
Well, that’s the point. Currency It IS 119400, the PR is reverting it back to the default 115200 |
I couldn't find any info on why it's changed to Is there something I am missing here? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The esptool expects an initial detection phase where baud rate is 115200. Setting it to 119400 is causing wacky warnings like detecting an incorrect crystal frequency:
It still works fine with 119400 rate, but it creates a warning and there's no need to distinguish Vidor from the other MKR boards here.