Submit from wallet with fee payer support #189

gregnazario · 2023-08-31T05:44:19Z

Followup from previous fee payer PR, which adds support for submitting from a wallet directly.

I'm still working on testing it with Petra or another wallet directly to ensure it is the right model.

aptos-labs/aptos-core#9896

This has been tested with petra as a wallet plugin here aptos-labs/petra-plugin-wallet-adapter#10

0xmaayan

can you run changeset so we include it in next version release

0xmaayan · 2023-10-30T22:26:32Z

packages/wallet-adapter-core/src/WalletCore.ts

@@ -501,4 +487,113 @@ export class WalletCore extends EventEmitter<WalletCoreEvents> {
      throw new WalletSignMessageAndVerifyError(errMsg).message;
    }
  }
+
+  async prepRawTransaction(input: RawTransactionPrepPayload): Promise<AnyRawTransaction> {


can we add some comments on what this function does

Oof, I forgot documentation in my mad rush, let me fix that

0xmaayan · 2023-10-30T22:27:19Z

packages/wallet-adapter-core/src/WalletCore.ts

+    }
+  }
+
+  async signRawTransaction(


so this can be used for any transaction single/feepayer/agent?

0xmaayan · 2023-10-30T22:28:14Z

packages/wallet-adapter-core/src/WalletCore.ts

+    }
+  }
+
+  private getClient(): Provider {


what is the need for this function?

It's used above.

Basically, the sequence number and chain ID need to be pulled prior to generating the transaction. This can alternatively be sent to the wallet instead of doing this.

0xmaayan

We should document those changes in https://github.com/aptos-labs/aptos-wallet-adapter/tree/main/packages/wallet-adapter-react

tbh, this becomes very complex, and with the new v2 support it would become even more complex. I think we need to start working on adapter v2 and then push wallets to support v2. We are going to end up with 3 different functions to submit a transaction

gregnazario · 2023-10-31T01:05:48Z

We should document those changes in https://github.com/aptos-labs/aptos-wallet-adapter/tree/main/packages/wallet-adapter-react

tbh, this becomes very complex, and with the new v2 support it would become even more complex. I think we need to start working on adapter v2 and then push wallets to support v2. We are going to end up with 3 different functions to submit a transaction

Unfortunately there is always going to be minimally a 3 step process to submitting a transaction.

Generate the transaction (we can actually do this locally), but I've added it here for convenience so that users don't have to reimplement it. The new SDK can just handle this on it's own.
Sign by one party (the primary signer, or the fee payer)
Sign and submit by the other party (primary signer or the fee payer)

This could be reduced down to mostly client logic, but this is to simplify the process since the fee payer key will have to be out of the client anyways. If a wallet decides to sponsor the transactions itself, it can possibly skip over some of that to one call by the user.

0xmaayan · 2023-10-31T01:11:09Z

We should document those changes in https://github.com/aptos-labs/aptos-wallet-adapter/tree/main/packages/wallet-adapter-react
tbh, this becomes very complex, and with the new v2 support it would become even more complex. I think we need to start working on adapter v2 and then push wallets to support v2. We are going to end up with 3 different functions to submit a transaction

Unfortunately there is always going to be minimally a 3 step process to submitting a transaction.

Generate the transaction (we can actually do this locally), but I've added it here for convenience so that users don't have to reimplement it. The new SDK can just handle this on it's own.

Sign by one party (the primary signer, or the fee payer)

Sign and submit by the other party (primary signer or the fee payer)

This could be reduced down to mostly client logic, but this is to simplify the process since the fee payer key will have to be out of the client anyways. If a wallet decides to sponsor the transactions itself, it can possibly skip over some of that to one call by the user.

I was mostly talking about signAndSubmitTransaction, signAndSubmitRawTransaction, submitTransaction (v2)

This adds 3 new APIs, prepRawTransaction, signRawTransaction, and signAndSubmitRawTransaction. Prep will create a multiagent or fee payer transaction accordingly, unsigned with information from the wallet on sequence number and chain id. Then all parties can sign the transaction with signRawTransaction, and the last party can sign with signAndSubmitRawTransaction to sign and send it off as the sender.

gregnazario · 2023-10-31T01:22:46Z

We should document those changes in https://github.com/aptos-labs/aptos-wallet-adapter/tree/main/packages/wallet-adapter-react
tbh, this becomes very complex, and with the new v2 support it would become even more complex. I think we need to start working on adapter v2 and then push wallets to support v2. We are going to end up with 3 different functions to submit a transaction

Unfortunately there is always going to be minimally a 3 step process to submitting a transaction.

Generate the transaction (we can actually do this locally), but I've added it here for convenience so that users don't have to reimplement it. The new SDK can just handle this on it's own.

Sign by one party (the primary signer, or the fee payer)

Sign and submit by the other party (primary signer or the fee payer)

This could be reduced down to mostly client logic, but this is to simplify the process since the fee payer key will have to be out of the client anyways. If a wallet decides to sponsor the transactions itself, it can possibly skip over some of that to one call by the user.

I was mostly talking about signAndSubmitTransaction, signAndSubmitRawTransaction, submitTransaction (v2)

Yes, we need to collapse them into 1 for the new SDK and the future of the API.

We could just drop this and merge it in with the rest on the outside interface, but the wallets still need the inner interface.

gregnazario · 2023-11-16T05:23:19Z

Closing in favor of SDK v2 bindings

gregnazario requested a review from hardsetting August 31, 2023 05:44

gregnazario force-pushed the fee-payer-submit branch 2 times, most recently from 841f08a to 8f15a9e Compare August 31, 2023 05:50

gregnazario marked this pull request as ready for review September 1, 2023 20:52

gregnazario requested review from 0xmaayan and banool as code owners September 1, 2023 20:52

gregnazario mentioned this pull request Sep 1, 2023

[Feature Request] Support Sponsored (and multi agent) transactions in Wallet adapter aptos-labs/aptos-core#9896

Closed

3 tasks

gregnazario force-pushed the fee-payer-submit branch from 9f9a7b9 to cb6a025 Compare October 30, 2023 18:38

0xmaayan reviewed Oct 30, 2023

View reviewed changes

gregnazario force-pushed the fee-payer-submit branch from cb6a025 to 298ade8 Compare October 30, 2023 22:13

0xmaayan reviewed Oct 30, 2023

View reviewed changes

gregnazario force-pushed the fee-payer-submit branch 2 times, most recently from b63f928 to 3575f8e Compare October 30, 2023 22:34

0xmaayan reviewed Oct 30, 2023

View reviewed changes

0xmaayan approved these changes Oct 30, 2023

View reviewed changes

gregnazario force-pushed the fee-payer-submit branch from 3575f8e to f31f4df Compare October 31, 2023 01:21

gregnazario closed this Nov 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Submit from wallet with fee payer support #189

Submit from wallet with fee payer support #189

gregnazario commented Aug 31, 2023 •

edited

Loading

0xmaayan left a comment

0xmaayan Oct 30, 2023

gregnazario Oct 30, 2023

0xmaayan Oct 30, 2023

gregnazario Oct 30, 2023

0xmaayan Oct 30, 2023

gregnazario Oct 30, 2023 •

edited

Loading

0xmaayan left a comment

gregnazario commented Oct 31, 2023

0xmaayan commented Oct 31, 2023

gregnazario commented Oct 31, 2023

gregnazario commented Nov 16, 2023

Submit from wallet with fee payer support #189

Submit from wallet with fee payer support #189

Conversation

gregnazario commented Aug 31, 2023 • edited Loading

0xmaayan left a comment

Choose a reason for hiding this comment

0xmaayan Oct 30, 2023

Choose a reason for hiding this comment

gregnazario Oct 30, 2023

Choose a reason for hiding this comment

0xmaayan Oct 30, 2023

Choose a reason for hiding this comment

gregnazario Oct 30, 2023

Choose a reason for hiding this comment

0xmaayan Oct 30, 2023

Choose a reason for hiding this comment

gregnazario Oct 30, 2023 • edited Loading

Choose a reason for hiding this comment

0xmaayan left a comment

Choose a reason for hiding this comment

gregnazario commented Oct 31, 2023

0xmaayan commented Oct 31, 2023

gregnazario commented Oct 31, 2023

gregnazario commented Nov 16, 2023

gregnazario commented Aug 31, 2023 •

edited

Loading

gregnazario Oct 30, 2023 •

edited

Loading