Fix handling of file: module URIs with non-ASCII characters

Closes #653

pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java

@@ -29,6 +29,7 @@
 import java.nio.file.Path;
 import java.util.List;
 import java.util.Map;
+import org.pkl.core.PklBugException;
 import org.pkl.core.SecurityManager;
 import org.pkl.core.SecurityManagerException;
 import org.pkl.core.packages.Dependency;
@@ -325,10 +326,19 @@ public ResolvedModuleKey resolve(SecurityManager securityManager)
  if (java.io.File.separatorChar == '\\' && uriPath != null && uriPath.contains("\\")) {
  throw new FileNotFoundException();
  }
- var realPath = Path.of(uri).toRealPath();
- var resolvedUri = realPath.toUri();
- securityManager.checkResolveModule(resolvedUri);
- return ResolvedModuleKeys.file(this, resolvedUri, realPath);
+
+ // Path.of(URI) throws on non-ASCII characters so the module URI here must be normalized to
+ // ASCII
+ // Unfortunately there's no way to go from URI -> ASCII URI directly
+ // so this must transform URI -> ASCII String -> ASCII URI
+ try {
+ var realPath = Path.of(new URI(uri.toASCIIString())).toRealPath();
+ var resolvedUri = realPath.toUri();
+ securityManager.checkResolveModule(resolvedUri);
+ return ResolvedModuleKeys.file(this, resolvedUri, realPath);
+ } catch (URISyntaxException e) {
+ throw new PklBugException("File module URI could not be normalized to ASCII", e);
+ }
  }
 
  @Override

pkl-core/src/test/files/LanguageSnippetTests/input/modules/日本語.pkl

@@ -0,0 +1,6 @@
+// covers https://github.com/apple/pkl/issues/653
+日本語 = "Japanese language"
+readOne = read("日本語.pkl").text
+readGlob = read*("./日*.pkl").keys
+importOne = import("日本語.pkl").readOne
+importGlob = import*("./日*.pkl").keys

pkl-core/src/test/files/LanguageSnippetTests/output/modules/日本語.pcf

@@ -0,0 +1,21 @@
+日本語 = "Japanese language"
+readOne = """
+ // covers https://github.com/apple/pkl/issues/653
+ 日本語 = "Japanese language"
+ readOne = read("日本語.pkl").text
+ readGlob = read*("./日*.pkl").keys
+ importOne = import("日本語.pkl").readOne
+ importGlob = import*("./日*.pkl").keys
+ 
+ """
+readGlob = Set("./日本語.pkl")
+importOne = """
+ // covers https://github.com/apple/pkl/issues/653
+ 日本語 = "Japanese language"
+ readOne = read("日本語.pkl").text
+ readGlob = read*("./日*.pkl").keys
+ importOne = import("日本語.pkl").readOne
+ importGlob = import*("./日*.pkl").keys
+ 
+ """
+importGlob = Set("./日本語.pkl")