[2/x] Refactor root field builder for deferred named fragments #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm gonna merge this into #74 so the whole root field builder work can be evaluated as a whole. Especially since this one makes changes to code that's already in that PR. |
calvincestari
merged commit 64a88e4
into
defer/root-field-builder-inline-fragments
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This second PR for apollographql/apollo-ios#3141 refactors the root field builder to build deferred named fragments into the IR. The next PR will generate selection sets from the refactored IR.
containsDeferredFragment; moved to where the scope condition is modified to include the defer condition..fragmentSpread