-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include tests into ApolloPaginationTests target #70
Conversation
# Conflicts: # Project.swift
f51b310
to
649e9dc
Compare
let pageInfo: [AnyHashable: AnyHashable] = [ | ||
"__typename": "PageInfo", | ||
"endCursor": "Y3Vyc29yMg==", | ||
"hasNextPage": true | ||
] | ||
let friends: [[String: AnyHashable]] = [ | ||
[ | ||
"__typename": "Human", | ||
"name": "Luke Skywalker", | ||
"id": "1000", | ||
], | ||
[ | ||
"__typename": "Human", | ||
"name": "Han Solo", | ||
"id": "1002", | ||
] | ||
] | ||
let friendsConnection: [String: AnyHashable] = [ | ||
"__typename": "FriendsConnection", | ||
"totalCount": 3, | ||
"friends": friends, | ||
"pageInfo": pageInfo | ||
] | ||
|
||
let hero: [String: AnyHashable] = [ | ||
"__typename": "Droid", | ||
"id": "2001", | ||
"name": "R2-D2", | ||
"friendsConnection": friendsConnection | ||
] | ||
|
||
let data: [String: AnyHashable] = [ | ||
"hero": hero | ||
] | ||
|
||
return [ | ||
"data": data | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to know if y'all have a better solution for this -- I noticed that intermingling string
and int
types leads to Swift being unhappy for literals like this, which had me declare chunks as a workaround -- any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, want to give @AnthonyMDev a chance to review as well since he is more familiar with this work overall than I am
Closing in favor of #80, which re-writes all tests by necessity. |
Ideally this would be pointed at #69, since this PR is based on that one.
This PR:
Must be merged after: #69