Include tests into ApolloPaginationTests target #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Project.swift
Iron-Ham
force-pushed
the
hs/pagination-tests-incl
branch
from
f51b310
to
649e9dc
Compare
Iron-Ham
commented
Oct 11, 2023
Comment on lines
82
to
119
| let pageInfo: [AnyHashable: AnyHashable] = [ | ||
| "__typename": "PageInfo", | ||
| "endCursor": "Y3Vyc29yMg==", | ||
| "hasNextPage": true | ||
| ] | ||
| let friends: [[String: AnyHashable]] = [ | ||
| [ | ||
| "__typename": "Human", | ||
| "name": "Luke Skywalker", | ||
| "id": "1000", | ||
| ], | ||
| [ | ||
| "__typename": "Human", | ||
| "name": "Han Solo", | ||
| "id": "1002", | ||
| ] | ||
| ] | ||
| let friendsConnection: [String: AnyHashable] = [ | ||
| "__typename": "FriendsConnection", | ||
| "totalCount": 3, | ||
| "friends": friends, | ||
| "pageInfo": pageInfo | ||
| ] | ||
|
|
||
| let hero: [String: AnyHashable] = [ | ||
| "__typename": "Droid", | ||
| "id": "2001", | ||
| "name": "R2-D2", | ||
| "friendsConnection": friendsConnection | ||
| ] | ||
|
|
||
| let data: [String: AnyHashable] = [ | ||
| "hero": hero | ||
| ] | ||
|
|
||
| return [ | ||
| "data": data | ||
| ] |
There was a problem hiding this comment.
Would love to know if y'all have a better solution for this -- I noticed that intermingling string and int types leads to Swift being unhappy for literals like this, which had me declare chunks as a workaround -- any thoughts?
BobaFetters
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
I think this looks good, want to give @AnthonyMDev a chance to review as well since he is more familiar with this work overall than I am
This was referenced Oct 13, 2023
|
Closing in favor of #80, which re-writes all tests by necessity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally this would be pointed at #69, since this PR is based on that one.
This PR:
Must be merged after: #69