-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call the completions in the given callback queue when CompletionManager
is getting deinitialized
#503
Conversation
@haldun: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
❌ Docs Preview FailedError
|
Thanks for this PR! Would you be able to sign our CLA so we can merge this? @Iron-Ham, this looks right to me, any concerns on your end? |
@AnthonyMDev it looks good to me! @haldun committed this to our vendored |
…ger` is getting deinitialized (#503)
…ger` is getting deinitialized (apollographql/apollo-ios-dev#503)
5a63f769 Call the completions in the given callback queue when `CompletionManager` is getting deinitialized (#503) git-subtree-dir: apollo-ios-pagination git-subtree-split: 5a63f769e6c99e084182e018a57e3b97a8bc7826
…given callback queue when `CompletionManager` is getting deinitialized git-subtree-dir: apollo-ios-pagination git-subtree-mainline: 524d558 git-subtree-split: 5a63f769e6c99e084182e018a57e3b97a8bc7826
In
CompletionManager.deinit
we directly call each of the completions but instead we should use.execute
to ensure that the completion closures are being called in the given queue.