Call the completions in the given callback queue when CompletionManager is getting deinitialized
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haldun: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
❌ Docs Preview FailedError |
|
Thanks for this PR! Would you be able to sign our CLA so we can merge this? @Iron-Ham, this looks right to me, any concerns on your end? |
|
@AnthonyMDev it looks good to me! @haldun committed this to our vendored |
AnthonyMDev
approved these changes
Oct 10, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Oct 10, 2024
…ger` is getting deinitialized (#503)
BobaFetters
pushed a commit
to apollographql/apollo-ios-pagination
that referenced
this pull request
Oct 10, 2024
…ger` is getting deinitialized (apollographql/apollo-ios-dev#503)
BobaFetters
pushed a commit
that referenced
this pull request
Oct 10, 2024
5a63f769 Call the completions in the given callback queue when `CompletionManager` is getting deinitialized (#503) git-subtree-dir: apollo-ios-pagination git-subtree-split: 5a63f769e6c99e084182e018a57e3b97a8bc7826
BobaFetters
pushed a commit
that referenced
this pull request
Oct 10, 2024
…given callback queue when `CompletionManager` is getting deinitialized git-subtree-dir: apollo-ios-pagination git-subtree-mainline: 524d558 git-subtree-split: 5a63f769e6c99e084182e018a57e3b97a8bc7826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
CompletionManager.deinitwe directly call each of the completions but instead we should use.executeto ensure that the completion closures are being called in the given queue.