Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MockSchemaMetadata actor isolation #496

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix MockSchemaMetadata actor isolation #496

merged 1 commit into from
Sep 30, 2024

Conversation

AnthonyMDev
Copy link
Contributor

This is a fix for broken tests due to #493 being accidentally merged too early.

In order to properly support Swift Concurrency, tests that alter the MockSchemaMetadata must be marked as MainActor.

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 66968e9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/66fb143413408c00084b1401

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 66968e9
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/66fb1434115bcd00084c8e84

calvincestari
calvincestari approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These concurrency changes just end up sprawling everywhere. Thanks for the fix.

@AnthonyMDev AnthonyMDev merged commit 9c139b3 into main Sep 30, 2024
36 of 38 checks passed
@AnthonyMDev AnthonyMDev deleted the TestCacheProvider-async branch September 30, 2024 21:57
BobaFetters pushed a commit that referenced this pull request Sep 30, 2024
@AnthonyMDev
Fix MockSchemaMetadata actor isolation (#496)
a805cc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyMDev @calvincestari