Adding debugDescription to SelectionSets #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding debugDescription through CustomDebugStringConvertible to SelectionSets
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
BobaFetters
commented
Jul 2, 2024
| @@ -117,6 +117,10 @@ extension SelectionSet { | |||
| @inlinable public static func ==(lhs: Self, rhs: Self) -> Bool { | |||
| return lhs.__data == rhs.__data | |||
| } | |||
|
|
|||
| public var debugDescription: String { | |||
| return "\(self.__data._data as AnyObject)" | |||
There was a problem hiding this comment.
Should this print more than the data inside the DataDict, like the fulfilledFragments etc? And are we good with a readable format like provided by casting to AnyObject like the screenshot or do we want to manually create an output from keys/values?
calvincestari
approved these changes
Jul 2, 2024
BobaFetters
added a commit
that referenced
this pull request
Jul 2, 2024
BobaFetters
added a commit
to apollographql/apollo-ios
that referenced
this pull request
Jul 2, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jul 2, 2024
fe326385 Adding debugDescription to SelectionSets (#412) git-subtree-dir: apollo-ios git-subtree-split: fe32638504379a4855d63141e62b30c10684c218
BobaFetters
pushed a commit
that referenced
this pull request
Jul 2, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: 0df6da0 git-subtree-split: fe32638504379a4855d63141e62b30c10684c218
AnthonyMDev
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debugDescriptionthroughCustomDebugStringConvertibletoSelectionSetCloses apollographql/apollo-ios#3374