Selectively run Tuist Generation when there are changes to the Tuist configuration #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simple follow-up has been placed into #80 (I don't mind removing it, but unfortunately since I don't have access to the The follow up is basically: Only run the pagination tests when there are changes that could impact Pagination. Namely: If there are changes in Pagination, its tests, or |
|
@Iron-Ham Thanks for looking into/adding this! We had talked about maybe trying to filter selectively based on changes in |
|
Assuming i can get it to play nice with the matrix, it'd be a decent jumping off point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to speed up CI & to save y'all some actions runner minutes.
Running
Tuist generateas a step testing the validity of the project shouldn't be necessary if there have been no changes to the configuration. To verify proper function: I will branch off of this PR with a change to Tuist. This pull request, having no changes to the configuration shouldn't run the action. The other, with changes to the configuration, should run the action.cc: @BobaFetters, since you have the most context on the configuration: Is the filter I've setup sufficient?
Edit: See #104 for an example of a pull request that triggers running
Run Tuist Generation.EDIT2: I see that the broader matrix for testing this is reliant on the Tuist generate step. 🤔 Another thought would be to selectively filter & run tests based on the filter. I'll give it some more thought.