Fix a leak related to use of function used in a closure

apollographql · Aug 8, 2024 · af5b76c · af5b76c
1 parent 0eda6f3
commit af5b76c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/apollo-ios/Sources/Apollo/ApolloStore.swift b/apollo-ios/Sources/Apollo/ApolloStore.swift
@@ -202,8 +202,12 @@ public class ApolloStore {
 
   public class ReadTransaction {
     fileprivate let cache: any NormalizedCache
+
+    fileprivate lazy var loader: DataLoader<CacheKey, Record> = DataLoader { [weak self] batchLoad in
+          guard let self else { return [:] }
+          return try cache.loadRecords(forKeys: batchLoad)
+    }
 
-    fileprivate lazy var loader: DataLoader<CacheKey, Record> = DataLoader(self.cache.loadRecords)
     fileprivate lazy var executor = GraphQLExecutor(
       executionSource: CacheDataExecutionSource(transaction: self)
     )