Removing legacy iOS version test for now

apollographql · Oct 16, 2023 · 14f657d · 14f657d
1 parent 3837c12
commit 14f657d
Showing 1 changed file with 69 additions and 69 deletions.
diff --git a/.github/workflows/release-check.yml b/.github/workflows/release-check.yml
@@ -150,75 +150,75 @@ jobs:
         path: |
           TestResults/ResultBundle.zip
 
-  legacy-unit-test:
-    runs-on: macos-11
-    needs: tuist-generation
-    timeout-minutes: 20
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          # iOS 14.4
-          - destination: platform=iOS Simulator,OS=14.4,name=iPhone 12
-            scheme: ApolloTests
-            test-plan: Apollo-CITestPlan
-            name: Apollo Unit Tests - iOS 14.4
-    name: ${{ matrix.name }}
-    steps:
-    - name: Checkout Repo
-      uses: actions/checkout@v3
-    # Caching for apollo-ios and apollo-ios-codegen SPM dependencies
-    # - uses: actions/cache@v3
-    #   with:
-    #     path: ./DerivedData/SourcePackages
-    #     key: ${{ runner.os }}-spm-${{ hashFiles('./apollo-ios/Package.resolved') }}-${{ hashFiles('./apollo-ios-codegen/Package.resolved') }}
-    - name: Retrieve Build Cache
-      uses: actions/cache@v3
-      with:
-        path: |
-          ./ApolloDev.xcodeproj
-          ./ApolloDev.xcworkspace
-          ./Derived/*
-        key: ${{ github.run_id }}-dependencies
-        fail-on-cache-miss: true
-    - uses: maxim-lobanov/setup-xcode@v1
-      with:
-        xcode-version: 12.4.0
-    - name: Build and Test
-      uses: ./.github/actions/build-and-run-unit-tests
-      with:
-        destination: ${{ matrix.destination }}
-        scheme: ${{ matrix.scheme }}
-        test-plan: ${{ matrix.test-plan }}
-    - name: Run-JS-Tests
-      if: ${{ matrix.run-js-tests == true }}
-      shell: bash
-      working-directory: apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/
-      run: |
-        npm install && npm test
-    - name: Save xcodebuild logs
-      uses: actions/upload-artifact@v3
-      with:
-        name: ${{ matrix.name }}-logs
-        path: |
-          DerivedData/Logs/Build
-    - name: Save crash logs
-      uses: actions/upload-artifact@v3
-      with:
-        name: ${{ matrix.name }}-crashes
-        path: |
-          ~/Library/Logs/DiagnosticReports
-    - name: Zip Result Bundle
-      shell: bash
-      working-directory: TestResults
-      run: |
-        zip -r ResultBundle.zip ResultBundle.xcresult
-    - name: Save test results
-      uses: actions/upload-artifact@v3
-      with:
-        name: ${{ matrix.name }}-results
-        path: |
-          TestResults/ResultBundle.zip
+  # legacy-unit-test:
+  #   runs-on: macos-11
+  #   needs: tuist-generation
+  #   timeout-minutes: 20
+  #   strategy:
+  #     fail-fast: false
+  #     matrix:
+  #       include:
+  #         # iOS 14.4
+  #         - destination: platform=iOS Simulator,OS=14.4,name=iPhone 12
+  #           scheme: ApolloTests
+  #           test-plan: Apollo-CITestPlan
+  #           name: Apollo Unit Tests - iOS 14.4
+  #   name: ${{ matrix.name }}
+  #   steps:
+  #   - name: Checkout Repo
+  #     uses: actions/checkout@v3
+  #   # Caching for apollo-ios and apollo-ios-codegen SPM dependencies
+  #   # - uses: actions/cache@v3
+  #   #   with:
+  #   #     path: ./DerivedData/SourcePackages
+  #   #     key: ${{ runner.os }}-spm-${{ hashFiles('./apollo-ios/Package.resolved') }}-${{ hashFiles('./apollo-ios-codegen/Package.resolved') }}
+  #   - name: Retrieve Build Cache
+  #     uses: actions/cache@v3
+  #     with:
+  #       path: |
+  #         ./ApolloDev.xcodeproj
+  #         ./ApolloDev.xcworkspace
+  #         ./Derived/*
+  #       key: ${{ github.run_id }}-dependencies
+  #       fail-on-cache-miss: true
+  #   - uses: maxim-lobanov/setup-xcode@v1
+  #     with:
+  #       xcode-version: 12.4.0
+  #   - name: Build and Test
+  #     uses: ./.github/actions/build-and-run-unit-tests
+  #     with:
+  #       destination: ${{ matrix.destination }}
+  #       scheme: ${{ matrix.scheme }}
+  #       test-plan: ${{ matrix.test-plan }}
+  #   - name: Run-JS-Tests
+  #     if: ${{ matrix.run-js-tests == true }}
+  #     shell: bash
+  #     working-directory: apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/
+  #     run: |
+  #       npm install && npm test
+  #   - name: Save xcodebuild logs
+  #     uses: actions/upload-artifact@v3
+  #     with:
+  #       name: ${{ matrix.name }}-logs
+  #       path: |
+  #         DerivedData/Logs/Build
+  #   - name: Save crash logs
+  #     uses: actions/upload-artifact@v3
+  #     with:
+  #       name: ${{ matrix.name }}-crashes
+  #       path: |
+  #         ~/Library/Logs/DiagnosticReports
+  #   - name: Zip Result Bundle
+  #     shell: bash
+  #     working-directory: TestResults
+  #     run: |
+  #       zip -r ResultBundle.zip ResultBundle.xcresult
+  #   - name: Save test results
+  #     uses: actions/upload-artifact@v3
+  #     with:
+  #       name: ${{ matrix.name }}-results
+  #       path: |
+  #         TestResults/ResultBundle.zip
 
   run-codegen-test-configurations:
     runs-on: macos-13