update all the place to show user name instead of ID

[kalavt]

What's the purpose of this PR

update all the place to show user name instead of ID

Brief changelog

update all the place to show user name instead of ID

Follow this checklist to help us incorporate your contribution quickly and easily:

• Read the Contributing Guide before making this pull request.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit tests to verify the code.
• Run mvn clean test to make sure this pull request doesn't break anything.
• Update the CHANGES log.

Summary by CodeRabbit

• New Features

  • Enhanced user information display by showing user names instead of user IDs in the settings and system role management interfaces.
  • Improved functionality for user role management by ensuring correct user IDs are utilized for deletion actions.

• Bug Fixes

  • Simplified data handling in the permission controller by directly returning detailed user information, improving performance and clarity.

[coderabbitai]

Walkthrough

The changes involve modifications to the PermissionController class, updating the return type of the getCreateApplicationRoleUsers method from a list of user IDs to a set of UserInfo objects. Additionally, the HTML templates for user settings and system role management have been updated to display user names instead of IDs, enhancing user interface clarity and interaction specificity.

Changes

File	Change Summary
.../PermissionController.java	Updated getCreateApplicationRoleUsers method to return Set<UserInfo> instead of List<String>.
.../static/app/setting.html	Changed button binding from user.userId to user.name for improved clarity. Added a newline before </html>.
.../static/system-role-manage.html	Updated ng-bind to use user.name and ng-click to use user.userId for better specificity.

Poem

Hop along, the changes bright,
User names now take the light!
From IDs we’ve made the switch,
Clarity is quite the pitch.
In code and view, we dance and play,
A better path, hip-hip-hooray! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f4a0236 and 88571d0.

Files selected for processing (3)

• apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/PermissionController.java (1 hunks)
• apollo-portal/src/main/resources/static/app/setting.html (2 hunks)
• apollo-portal/src/main/resources/static/system-role-manage.html (1 hunks)

Additional comments not posted (6)

apollo-portal/src/main/resources/static/system-role-manage.html (2)

68-68: LGTM!

The ng-bind directive is correctly updated to bind user.name, improving the user interface.

The code changes are approved.

---

71-71: LGTM!

The ng-click directive is correctly updated to use user.userId, ensuring the correct identifier is passed to the function.

The code changes are approved.

apollo-portal/src/main/resources/static/app/setting.html (2)

78-78: LGTM!

The ng-bind directive is correctly updated to bind user.name, improving the user interface.

The code changes are approved.

---

223-223: LGTM!

The newline added before the closing </html> tag is a minor formatting improvement.

The code changes are approved.

apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/PermissionController.java (2)

326-326: LGTM!

The return type change from List<String> to Set<UserInfo> enhances the method's output by providing more detailed user information.

The code changes are approved.

---

327-327: LGTM!

The implementation update to return a set of UserInfo objects simplifies the control flow and improves performance.

The code changes are approved.

[kalavt]

hello @nobodyiam @shoothzj
may I request your review and approve for this PR?

[shoothzj]

This changes the compatibility of REST API. I would suggest to design a new API, @nobodyiam WDYT?

[nobodyiam]

This is a breaking change. @kalavt would you please help to describe the background of this change?

[kalavt]

With LDAP and OAUTH login, user ID is a meaning less string which looks ugly on multiple place of UI,
better to show user's name instead of ID.

[kalavt]

@shoothzj @nobodyiam let me know if you considering we shall implement a another API for keep the backward capability.

[nobodyiam]

1. We need to add a new api to retrieve the user info
2. It's better to display the user name as well as the user id, e.g. xxName(xxId)

[stale]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!