Merge pull request #407 from vincentchalamon/fix/issues/405

Allow to declare multiple operations using the same class
api-platform · Jun 29, 2023 · 1c59759 · 1c59759
2 parents 7d0a356 + ef6e444
commit 1c59759
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/AttributeGenerator/ApiPlatformCoreAttributeGenerator.php b/src/AttributeGenerator/ApiPlatformCoreAttributeGenerator.php
@@ -78,6 +78,13 @@ public function generateClassAttributes(Class_ $class): array
  } else {
  $arguments['operations'] = [];
  foreach ($class->operations as $operationMetadataClass => $methodConfig) {
+ // https://github.com/api-platform/schema-generator/issues/405
+ if (\array_key_exists('class', $methodConfig ?? [])) {
+ /** @var string $operationMetadataClass */
+ $operationMetadataClass = $methodConfig['class'];
+ unset($methodConfig['class']);
+ }
+
  $arguments['operations'][] = new Literal(sprintf('new %s(...?:)',
  $operationMetadataClass,
  ), [$methodConfig ?? []]);

diff --git a/src/Model/Class_.php b/src/Model/Class_.php
@@ -47,7 +47,7 @@ abstract class Class_
  public bool $isAbstract = false;
  public bool $hasChild = false;
  public bool $isEmbeddable = false;
- /** @var array<string, ?array<string, string|int|bool|string[]|null>> */
+ /** @var array<string|int, ?array<string, string|int|bool|string[]|null>> */
  public array $operations = [];
 
  /**

diff --git a/tests/AttributeGenerator/ApiPlatformCoreAttributeGeneratorTest.php b/tests/AttributeGenerator/ApiPlatformCoreAttributeGeneratorTest.php
@@ -71,6 +71,13 @@ public function provideGenerateClassAttributesCases(): \Generator
  ];
  yield 'with operations' => [$class, [new Attribute('ApiResource', ['types' => ['https://schema.org/WithOperations'], 'operations' => [new Literal('new Get(...?:)', [['routeName' => 'api_about_get']])]])]];
 
+ $class = new SchemaClass('WithOperations', new RdfResource('https://schema.org/WithOperations', new RdfGraph()));
+ $class->operations = [
+ ['class' => 'Get', 'routeName' => 'api_about_get'],
+ ['class' => 'Get', 'routeName' => 'api_alternate_get'],
+ ];
+ yield 'with numeric operations' => [$class, [new Attribute('ApiResource', ['types' => ['https://schema.org/WithOperations'], 'operations' => [new Literal('new Get(...?:)', [['routeName' => 'api_about_get']]), new Literal('new Get(...?:)', [['routeName' => 'api_alternate_get']])]])]];
+
  $class = new SchemaClass('WithOperations', new RdfResource('https://schema.org/WithOperations', new RdfGraph()));
  $class->operations = [
  'item' => ['get' => ['route_name' => 'api_about_get']],