perf(laravel): Caching tables and indexes to avoid multiple queries #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault cache driver
soyuka
reviewed
Oct 24, 2024
| /** @var array<int, mixed> $indexes */ | ||
| $indexes = Cache::flexible('api-platform.indexes.'.$table, [5, 10], function () use ($schema, $table) { | ||
| return $schema->getIndexes($table); | ||
| }); |
There was a problem hiding this comment.
Interesting change, note also #6735. We already have a cache layer so that this isn't called more then once per metadata computation in production mode.
This cache is stored in memory ? File ? How do you make sure it's not stale ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
Cache::flexiblefrom Laravel to improve performance so that same table data is not requested multiple times and the request happens in the background