Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELP-WANTED][ZEPPELIN-5976] Support Flink 1.18 #4864

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Oct 5, 2024

What is this PR for?

Notice, that the patch does not work, I encountered an issue that I am unable to resolve, if someone is interested in this task, feel free to take over.

java.lang.RuntimeException: error reading Scala signature of org.apache.flink.table.api.ImplicitExpressionConversions: unsafe symbol x$2 (child of value <local api>) in runtime reflection universe
  at scala.reflect.internal.pickling.UnPickler.unpickle(UnPickler.scala:44)
  at scala.reflect.runtime.JavaMirrors$JavaMirror.unpickleClass(JavaMirrors.scala:622)

To reproduce the issue in local,

$ ./mvnw -pl flink/flink-scala-2.12 -Pflink-118 -Phadoop3 clean install -DskipTests -am
$ ./mvnw -pl flink/flink-scala-2.12 -Pflink-118 -Phadoop3 test

What type of PR is it?

Feature

Todos

What is the Jira issue?

ZEPPELIN-5976

How should this be tested?

  • Strongly recommended: add automated unit tests for any new or changed behavior
  • Outline any manual steps to test the PR here.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@pan3793
Copy link
Member Author

pan3793 commented Oct 5, 2024

An addition thought, the Flink community decided to deprecate all Scala APIs in Flink 1.18 and remove them in Flink 2.0, see more details at FLIP-265. What kind of Flink APIs you are using? Java, Scala, or Python? IMO the support of Flink Scala API in Zeppelin might be removed eventually.

@jongyoul
Copy link
Member

jongyoul commented Oct 5, 2024

If we need to change them completely, I prefer to use Java. Of course, other languages are good but our interpreter is based on Java so we'd better do it.

@pan3793
Copy link
Member Author

pan3793 commented Oct 5, 2024

this is not likely to be addressed quickly, and does not block the 0.12 release

@A-Maniovich
Copy link

Hello,

Thanks for that feature!

Is it possible to also add support for 1.19.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants