[ZEPPELIN-6075] Configuration for global Roles #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
force-pushed
the
globalRoles
branch
2 times, most recently
from
f929c4c
to
5c70491
Compare
seung-00
reviewed
Oct 6, 2024
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java
Outdated
Show resolved
Hide resolved
Comment on lines
327
to
311
| switch (confvar) { | ||
| case ZEPPELIN_OWNER_ROLES: | ||
| case ZEPPELIN_WRITER_ROLES: | ||
| case ZEPPELIN_READER_ROLES: | ||
| case ZEPPELIN_RUNNER_ROLES: | ||
| defaultRolesConf = zConf.getString(confvar); | ||
| break; | ||
| default: | ||
| LOGGER.warn("getDefaultRoles is used with {}, which is not valid", confvar); | ||
| break; | ||
| } |
There was a problem hiding this comment.
How about using a collection like EnumSet instead of a switch statement to manage valid roles? IMO, this simplifies the code and makes it easier to add or modify roles in the future.
private static final Set<ZeppelinConfiguration.ConfVars> VALID_CONF_VARS = EnumSet.of(
ZeppelinConfiguration.ConfVars.ZEPPELIN_OWNER_ROLES,
ZeppelinConfiguration.ConfVars.ZEPPELIN_WRITER_ROLES,
ZeppelinConfiguration.ConfVars.ZEPPELIN_READER_ROLES,
ZeppelinConfiguration.ConfVars.ZEPPELIN_RUNNER_ROLES
);
private Set<String> getDefaultRoles(ZeppelinConfiguration.ConfVars confvar) {
if (!VALID_CONF_VARS.contains(confvar)) {
LOGGER.warn("getDefaultRoles is used with {}, which is not valid", confvar);
return Collections.emptySet();
}
...
}There was a problem hiding this comment.
Thank you for your review. I have adapted the code and agree with your statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR adds global roles, which can be stored in the Zeppelin configuration.
What type of PR is it?
Feature
Todos
What is the Jira issue?
How should this be tested?
Questions: