Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2931] Create foreign pod e2e tests #932

Closed
wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Oct 24, 2024

What is this PR for?

e2e for foreign pod tracking

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2931

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Oct 24, 2024
@pbacsko pbacsko marked this pull request as draft October 24, 2024 16:45
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.02%. Comparing base (753e4f8) to head (8de95de).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
- Coverage   68.62%   68.02%   -0.60%     
==========================================
  Files          70       70              
  Lines        7675     9195    +1520     
==========================================
+ Hits         5267     6255     +988     
- Misses       2202     2732     +530     
- Partials      206      208       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko force-pushed the YUNIKORN-2931 branch 6 times, most recently from 381110b to 5d877a4 Compare October 24, 2024 19:09
@pbacsko pbacsko changed the title DRAFT [YUNIKORN-2931] Create foreign pod e2e tests [YUNIKORN-2931] Create foreign pod e2e tests Oct 25, 2024
@pbacsko pbacsko marked this pull request as ready for review October 25, 2024 07:36
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants