[YUNIKORN-2874] Fix reproducible builds when a release is generated #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the parent directory (containing the core and SI) is mounted into the Docker build when generating reproducible builds in release mode.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
=======================================
Coverage 68.20% 68.20%
=======================================
Files 70 70
Lines 7621 7621
=======================================
Hits 5198 5198
Misses 2215 2215
Partials 208 208 ☔ View full report in Codecov by Sentry. |
manirajv06
requested changes
Sep 17, 2024
We don't know for sure that a user has the different trees checked out in parallel directories. However, in the tarball build we do -- we check for this by the presence or absence of .gitignore (it won't be present in a tarball build). This way, builds work consistently if only k8shim is checked out, or when using a release tarball. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Ensure that the parent directory (containing the core and SI) is mounted into the Docker build when generating reproducible builds in release mode.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2874
How should this be tested?
Verified manually by applying this patch to a release tarball. When .gitignore is not detected, we mount the parent directory into the Docker build environment rather than just the shim dir.
Screenshots (if appropriate)
Questions: