[YUNIKORN-1957] Add e2e tests for user and group limits with wildcard #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbacsko
requested changes
Sep 6, 2024
Hi @pbacsko , Fixed the Linter. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
=======================================
Coverage 68.18% 68.18%
=======================================
Files 70 70
Lines 7606 7606
=======================================
Hits 5186 5186
- Misses 2212 2213 +1
+ Partials 208 207 -1 ☔ View full report in Codecov by Sentry. |
craigcondit
force-pushed
the
YUNIKORN-1957
branch
from
4c3249f
to
7f70e88
Compare
craigcondit
approved these changes
Sep 6, 2024
craigcondit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces user and group limit test enhancements in the
user_group_limit_test.gofile. It adds new test cases to verify the behavior of the scheduler when user and group limits are set and updated. The tests cover scenarios where the user and group limits are exceeded, not defined, and changed. The PR also includes tests for wildcard users and group limits. These enhancements ensure that the scheduler correctly handles user and group limits in various scenarios.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1957
How should this be tested?
Screenshots (if appropriate)
Questions: