-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1867] add priority offset e2e test #637
Conversation
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
=======================================
Coverage 70.90% 70.90%
=======================================
Files 52 52
Lines 8245 8245
=======================================
Hits 5846 5846
Misses 2195 2195
Partials 204 204 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing quite a few test failures on this, need to investigate and fix.
dcd789a
to
490f3e2
Compare
The root cause of error test cases is that we can't add child queue to a draining queue. In the first case, we add three queues Currently, the yunikorn-core will clean draining queues every 10 seconds. The duration is hardcoded in the source code. Users can't update it. Do we want to add the setting to the configuration? If yes, I can help to add it. CI failed job: https://github.com/apache/yunikorn-k8shim/actions/runs/5575867672/jobs/10202470269 |
A better approach is probably to use distinct queue names for different tests so that they don't conflict. |
Signed-off-by: Frank Yang <yangpoan@gmail.com>
Signed-off-by: Frank Yang <yangpoan@gmail.com>
490f3e2
to
1d433b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change looked more complicated due to diff layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
What is this PR for?
Add
priority.offset
property e2e test.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1867
How should this be tested?
Screenshots (if appropriate)
Questions: