Update to latest lint / shellcheck

Makefile

@@ -92,7 +92,7 @@ DOCKER_ARCH := amd64
 endif
 
 # shellcheck
-SHELLCHECK_VERSION=v0.8.0
+SHELLCHECK_VERSION=v0.9.0
 SHELLCHECK_BIN=${TOOLS_DIR}/shellcheck
 SHELLCHECK_ARCHIVE := shellcheck-$(SHELLCHECK_VERSION).$(OS).$(HOST_ARCH).tar.xz
 ifeq (darwin, $(OS))
@@ -106,7 +106,7 @@ endif
 endif
 
 # golangci-lint
-GOLANGCI_LINT_VERSION=1.51.2
+GOLANGCI_LINT_VERSION=1.53.3
 GOLANGCI_LINT_BIN=$(TOOLS_DIR)/golangci-lint
 GOLANGCI_LINT_ARCHIVE=golangci-lint-$(GOLANGCI_LINT_VERSION)-$(OS)-$(EXEC_ARCH).tar.gz
 GOLANGCI_LINT_ARCHIVEBASE=golangci-lint-$(GOLANGCI_LINT_VERSION)-$(OS)-$(EXEC_ARCH)
@@ -126,7 +126,7 @@ HELM_ARCHIVE=helm-$(HELM_VERSION)-$(OS)-$(EXEC_ARCH).tar.gz
 HELM_ARCHIVE_BASE=$(OS)-$(EXEC_ARCH)
 
 # spark
-export SPARK_VERSION=$(shell cat .spark_version)
+export SPARK_VERSION=3.3.1
 export SPARK_HOME=$(BASE_DIR)$(TOOLS_DIR)/spark
 export SPARK_SUBMIT_CMD=$(SPARK_HOME)/bin/spark-submit
 export SPARK_PYTHON_IMAGE=docker.io/apache/spark-py:v$(SPARK_VERSION)

deployments/examples/spark/cmd/run.sh

@@ -30,7 +30,6 @@ usage() {
 case "$1" in
    --help)
        usage
-       exit 0
        ;;
 esac
 
@@ -101,14 +100,14 @@ if [ -f "$SPARK_BINARY_FILE_PATH" ]; then
   echo "The binary file $SPARK_BINARY_FILE_NAME has been cached!"
 else
   echo "The binary file $SPARK_BINARY_FILE_NAME did not exist, try to download."
-  wget https://archive.apache.org/dist/spark/spark-${SPARK_VERSION}/${SPARK_BINARY_FILE_NAME} -O "${SPARK_BINARY_FILE_PATH}"
+  wget "https://archive.apache.org/dist/spark/spark-${SPARK_VERSION}/${SPARK_BINARY_FILE_NAME}" -O "${SPARK_BINARY_FILE_PATH}"
 fi
 
 if [ -f "$SPARK_BINARY_FILE_CHECKSUM_FILE_PATH" ]; then
   echo "The binary checksum file $SPARK_BINARY_FILE_CHECKSUM_FILE_NAME has been cached!"
 else
   echo "The binary checksum file $SPARK_BINARY_FILE_CHECKSUM_FILE_NAME did not exist, try to download."
-  wget http://archive.apache.org/dist/spark/spark-${SPARK_VERSION}/${SPARK_BINARY_FILE_CHECKSUM_FILE_NAME} -O "${SPARK_BINARY_FILE_CHECKSUM_FILE_PATH}"
+  wget "http://archive.apache.org/dist/spark/spark-${SPARK_VERSION}/${SPARK_BINARY_FILE_CHECKSUM_FILE_NAME}" -O "${SPARK_BINARY_FILE_CHECKSUM_FILE_PATH}"
 fi
 
 if [[ "$SPARK_VERSION" < "3.2.1"  || "$SPARK_VERSION" == "3.2.1" ]]; then
@@ -123,7 +122,7 @@ if [[ "$SPARK_VERSION" < "3.2.1"  || "$SPARK_VERSION" == "3.2.1" ]]; then
   if [[ 'OK' == $(shasum -c -a 512 "$FORMATTED_SPARK_BINARY_FILE_CHECKSUM_FILE_PATH"  | awk '{print $2}') ]]; then
     echo "The checksum is matched!"
     echo "Try to remove the old unpacked dir and re-uncompress it"
-    rm -rf "$WORK_SPACE_ROOT"/spark-${SPARK_VERSION}-bin-hadoop${SPARK_HADOOP_VERSION}
+    rm -rf "$WORK_SPACE_ROOT"/spark-"${SPARK_VERSION}"-bin-hadoop"${SPARK_HADOOP_VERSION}"
     tar -xvzf "$SPARK_BINARY_FILE_PATH" -C "$WORK_SPACE_ROOT"
   else
     echo "The checksum is not matched, Removing the incompleted file, please download it again."
@@ -135,7 +134,7 @@ else
   if [[ $(shasum -a 512 "$SPARK_BINARY_FILE_PATH" | awk '{print $1}') == $(awk '{print $1}' < "$SPARK_BINARY_FILE_CHECKSUM_FILE_NAME") ]]; then
     echo "The checksum is matched!"
     echo "Try to remove the old unpacked dir and re-uncompress it"
-    rm -rf "$WORK_SPACE_ROOT"/spark-${SPARK_VERSION}-bin-hadoop${SPARK_HADOOP_VERSION}
+    rm -rf "$WORK_SPACE_ROOT"/spark-"${SPARK_VERSION}"-bin-hadoop"${SPARK_HADOOP_VERSION}"
     tar -xvzf "$SPARK_BINARY_FILE_PATH" -C "$WORK_SPACE_ROOT"
   else
     echo "The checksum is not matched, Removing the incompleted file, please download it again."
@@ -195,7 +194,7 @@ EOF
   --conf spark.executor.instances=${SPARK_EXECUTOR_NUM} \
   --conf spark.kubernetes.namespace=spark-test \
   --conf spark.kubernetes.executor.request.cores=1 \
-  --conf spark.kubernetes.container.image=${SPARK_DOCKER_IMAGE} \
+  --conf spark.kubernetes.container.image="${SPARK_DOCKER_IMAGE}" \
   --conf spark.kubernetes.authenticate.driver.serviceAccountName=spark \
   --conf spark.kubernetes.driver.podTemplateFile=../driver.yaml \
   --conf spark.kubernetes.executor.podTemplateFile=../executor.yaml \