Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ExternalMechanism.java to be RFC compliant #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update ExternalMechanism.java to be RFC compliant #48

wants to merge 2 commits into from

Commits on Aug 15, 2022

  1. Update ExternalMechanism.java to be RFC compliant 

    The SASL External mechanism is configured in this class (ExternalMechanism.java) of Apache qpid-jms.

We can notice that the initial response is configured in Line 28. It is always set to EMPTY (empty byte array defined here) and cannot be configured to a custom string that we can use as identity string. Hence this library is NOT RFC compliant

If we have to pass the authorization identity string to the server then we must configure the initial response of that client.
    @hariprasad-SAP
    hariprasad-SAP authored Aug 15, 2022
    Configuration menu
    Copy the full SHA
    249cb74 View commit details
    Browse the repository at this point in the history

  2. Added the import statement for StandardCharsets

    @hariprasad-SAP
    hariprasad-SAP authored Aug 15, 2022
    Configuration menu
    Copy the full SHA
    8032c29 View commit details
    Browse the repository at this point in the history