sys/config: Add option to skip dup check when saving values #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default value is written to config storage only if it changed since last stored value. This however requires that all stored values are read to determine last value and in case of conf_save this is done for each saved value which can take a lot of time. This adds option to skip that dup check and simply stores new value. This results in much faster writes at the expense of load times as there are more copies of the same value stored. Also conf_save will always write all exported values so this increase number of writes to flash. However, e.g. in case of large FCB used as config storage dup check on write can take much longer than simple read or store without dup checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default value is written to config storage only if it changed since last stored value. This however requires that all stored values are read to determine last value and in case of conf_save this is done for each saved value which can take a lot of time.
This adds option to skip that dup check and simply stores new value. This results in much faster writes at the expense of load times as there are more copies of the same value stored. Also conf_save will always write all exported values so this increase number of writes to flash. However, e.g. in case of large FCB used as config storage dup check on write can take much longer than simple read or store without dup checks.