hw/mcu/nordic: Add common flash and QSPI flash HAL #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-gorecki
force-pushed
the
common_flash
branch
2 times, most recently
from
75ae1f3
to
e58a064
Compare
m-gorecki
force-pushed
the
common_flash
branch
2 times, most recently
from
068357a
to
9da67d4
Compare
kasjer
reviewed
Aug 1, 2024
Comment on lines
22
to
25
| #include "nrf.h" | ||
| #include "nrf_hal.h" | ||
| #include <hal/hal_flash_int.h> | ||
| #include "nrfx_nvmc.h" |
There was a problem hiding this comment.
Mixing <> with "" looks inconsistent
Comment on lines
35
to
42
| static int nrf_flash_read(const struct hal_flash *dev, uint32_t address, | ||
| void *dst, uint32_t num_bytes); | ||
| static int nrf_flash_write(const struct hal_flash *dev, uint32_t address, | ||
| const void *src, uint32_t num_bytes); | ||
| static int nrf_flash_erase_sector(const struct hal_flash *dev, | ||
| uint32_t sector_address); | ||
| static int nrf_flash_sector_info(const struct hal_flash *dev, int idx, | ||
| uint32_t *address, uint32_t *sz); |
There was a problem hiding this comment.
with shorter function names second line is misaligned.
Same for hal_qspi.c
kasjer
requested changes
Aug 12, 2024
| .spi_mode = MYNEWT_VAL(QSPI_SPI_MODE), | ||
| .sck_freq = MYNEWT_VAL(QSPI_SCK_FREQ), | ||
| }, | ||
| .xip_offset = MYNEWT_VAL(QSPI_XIP_OFFSET), |
There was a problem hiding this comment.
QSPI_XIP_OFFSET is not defined for NRF52 based devices
| @@ -97,16 +94,13 @@ const struct hal_flash nrf91k_qspi_dev = { | |||
| }; | |||
|
|
|||
| static int | |||
| nrf91k_qspi_read(const struct hal_flash *dev, uint32_t address, | |||
| nrf_qspi_read(const struct hal_flash *dev, uint32_t address, | |||
There was a problem hiding this comment.
alignment lost after name was changed
| @@ -149,20 +135,14 @@ nrf91k_qspi_read(const struct hal_flash *dev, uint32_t address, | |||
| } | |||
|
|
|||
| static int | |||
| nrf91k_qspi_write(const struct hal_flash *dev, uint32_t address, | |||
| nrf_qspi_write(const struct hal_flash *dev, uint32_t address, | |||
There was a problem hiding this comment.
alignment lost after name was changed
| @@ -219,26 +180,58 @@ nrf91k_qspi_write(const struct hal_flash *dev, uint32_t address, | |||
| } | |||
|
|
|||
| static int | |||
| nrf91k_qspi_erase_sector(const struct hal_flash *dev, | |||
| nrf_qspi_erase_sector(const struct hal_flash *dev, | |||
There was a problem hiding this comment.
alignment lost after name was changed
| return 0; | ||
| } | ||
|
|
||
| static int | ||
| nrf91k_qspi_sector_info(const struct hal_flash *dev, int idx, | ||
| nrf_qspi_erase(const struct hal_flash *dev, uint32_t address, |
Comment on lines
+28
to
+30
| #define NRF_FLASH_SECTOR_SZ 1024 | ||
| #else | ||
| #define NRF_FLASH_SECTOR_SZ 4096 |
Comment on lines
+23
to
+25
| #include "nrf.h" | ||
| #include "nrf_hal.h" | ||
| #include "nrfx_nvmc.h" |
There was a problem hiding this comment.
using < > pair would be more consistent
| }; | ||
|
|
||
| static int | ||
| nrf_flash_read(const struct hal_flash *dev, uint32_t address, void *dst, |
There was a problem hiding this comment.
second line alignment mismatch
| } | ||
|
|
||
| static int | ||
| nrf_flash_write(const struct hal_flash *dev, uint32_t address, |
There was a problem hiding this comment.
second line alignment mismatch
| } | ||
|
|
||
| static int | ||
| nrf_flash_sector_info(const struct hal_flash *dev, int idx, |
There was a problem hiding this comment.
second line alignment mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.