hw/mcu/dialog: Keep GPIO mux powered if non-GPIO pins enabled #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any pin has non-GPIO function we should not allow PD_COM to be disabled since this will also reset GPIO mux settings and this can lead to unpredictable behavior. However, if there are no pins configured or all of them are used as standard GPIO, we can just latch their state and disable PD_COM safely.
Style check summaryNo suggestions at this time! |
kasjer
reviewed
Feb 5, 2021
| @@ -90,6 +90,7 @@ static struct hal_gpio_irq hal_gpio_irqs[HAL_GPIO_MAX_IRQ]; | |||
| #if MYNEWT_VAL(MCU_GPIO_RETAINABLE_NUM) >= 0 | |||
| static uint32_t g_mcu_gpio_latch_state[2]; | |||
| static uint8_t g_mcu_gpio_retained_num; | |||
| static uint32_t g_mcu_gpio_can_sleep; | |||
There was a problem hiding this comment.
for now this variable is used only with values 0/1 maybe uint32_t is too much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any pin has non-GPIO function we should not allow PD_COM to be
disabled since this will also reset GPIO mux settings and this can
lead to unpredictable behavior.
However, if there are no pins configured or all of them are used
as standard GPIO, we can just latch their state and disable PD_COM
safely.