Prep 4.8.0 beta00017 #795
Prep 4.8.0 beta00017 #795
Conversation
| @@ -0,0 +1,177 @@ | |||
| --- | |||
There was a problem hiding this comment.
The release notes need to be a separate PR from the website update. Release notes are added prior to the release vote, and the rest of these updates are added after a successful vote.
The release notes are only done this way because GitHub requires permissions to view the release notes and we send the vote out to the dev list, so many interested parties don't have those permissions. Not to mention, the draft release notes page changes URL every time it is updated.
I spotted a few other potential issues, but I will do a complete review once this is moved to a new PR.
There was a problem hiding this comment.
IMO we should remove the website update from this PR then, given the size of the release notes. If anyone is able to help with that, help is welcome.
There was a problem hiding this comment.
Alright. I will open a new PR. It seems simpler to remove one page from this PR than to move all of the other files to another PR along with the commit history, though. Is there a reason you suggested to do it the other way?
There was a problem hiding this comment.
My suggestion was only because the changes to the other files were smaller and not spread across commits like the release notes are, so it seemed they would be easier to revert. Feel free to take whatever approach is easiest.
|
|
||
| ### Remaining work | ||
|
|
||
| See **[Current Status](xref:contributing/current-status)** for more details on the remaining work |
There was a problem hiding this comment.
Yikes, we still link here? That current status page hasn't been updated in ages. But, maybe we should keep this link and address the link to the WIKI afterward.
People keep demanding current status, but don't seem to appreciate how much effort it takes to maintain something like that. It would be nice if we had some sort of high level view somewhere that is based off of open issues and milestones, tags, etc. It might be worth investigating the GitHub features Apache supports with asf.yaml to determine whether there is anything like that where we can provide visibility without too much extra effort.
| @@ -193,7 +193,7 @@ Here is an example project file for .NET 5 for testing a project named `MyCodecs | |||
| <PackageReference Include="nunit" Version="3.13.2" /> | |||
| <PackageReference Include="NUnit3TestAdapter" Version="3.17.0" /> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" /> | |||
| <PackageReference Include="Lucene.Net.TestFramework" Version="4.8.0-beta00016" /> | |||
| <PackageReference Include="Lucene.Net.TestFramework" Version="4.8.0-beta00017" /> | |||
There was a problem hiding this comment.
Let's bump the above to .NET 8 on line 183 and <TargetFramework>net0.0</TargetFramework> on line 189.
|
Looks like we also have a conflict to resolve before this can be merged. |
This adds 4.8.0-beta00017 version mentions for the project's website and API docs. The API docs haven't been generated yet. I am waiting to ensure we can prepare and publish the release before we update and push the actual docs.