Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep all null rows in table model flush #13883

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Keep all null rows in table model flush #13883

merged 2 commits into from
Oct 23, 2024

Conversation

HTHou
Copy link
Contributor

@HTHou HTHou commented Oct 23, 2024

Description

As title. Refer #13487.

Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
36.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.84%. Comparing base (576b6d5) to head (efea121).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #13883   +/-   ##
=========================================
  Coverage     39.83%   39.84%           
  Complexity       71       71           
=========================================
  Files          4153     4153           
  Lines        262907   262957   +50     
  Branches      32014    32020    +6     
=========================================
+ Hits         104727   104767   +40     
- Misses       158180   158190   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jt2594838 jt2594838 merged commit bbfc2f8 into master Oct 23, 2024
28 of 29 checks passed
@HTHou HTHou deleted the flush_keep_all_null branch October 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants