Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the serialize method of intermedia result of aggregation #13875

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Oct 22, 2024

Description

Content1

  1. Use ByteUtils but not DataOutputStream to improve the efficiency of serialize.
  2. Support TEXT/BLOB/STRING/BOOLEAN data type for max,min,max_by,min_by.
  3. max_by and min_by aggregation can not use statistics.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Project coverage is 39.84%. Comparing base (8bf2294) to head (e96f0af).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
.../operator/source/relational/aggregation/Utils.java 0.00% 41 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 0.00% 15 Missing ⚠️
...onal/aggregation/TableMaxMinByBaseAccumulator.java 0.00% 13 Missing ⚠️
.../source/relational/aggregation/AvgAccumulator.java 0.00% 6 Missing ⚠️
...ource/relational/aggregation/FirstAccumulator.java 0.00% 4 Missing ⚠️
.../relational/TableAggregationTableScanOperator.java 0.00% 3 Missing ⚠️
...rce/relational/aggregation/FirstByAccumulator.java 0.00% 2 Missing ⚠️
...source/relational/aggregation/LastAccumulator.java 0.00% 2 Missing ⚠️
...urce/relational/aggregation/LastByAccumulator.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13875      +/-   ##
============================================
+ Coverage     39.83%   39.84%   +0.01%     
  Complexity       71       71              
============================================
  Files          4153     4154       +1     
  Lines        262846   262839       -7     
  Branches      32005    32009       +4     
============================================
+ Hits         104692   104720      +28     
+ Misses       158154   158119      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 23, 2024

@JackieTien97 JackieTien97 merged commit 14346dc into master Oct 23, 2024
29 checks passed
@JackieTien97 JackieTien97 deleted the fix_serialize_method branch October 23, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants