Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe: Convert data types when data sync sink metadata does not match integration test #13208

Merged
merged 29 commits into from
Aug 28, 2024
Merged

Pipe: Convert data types when data sync sink metadata does not match integration test #13208

merged 29 commits into from
Aug 28, 2024

Conversation

luoluoyuyu
Copy link
Contributor

@luoluoyuyu luoluoyuyu commented Aug 16, 2024 •
edited
Loading

Description

As title

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@SteveYurongSu SteveYurongSu self-assigned this Aug 19, 2024
@luoluoyuyu luoluoyuyu marked this pull request as draft August 20, 2024 10:39
@luoluoyuyu luoluoyuyu marked this pull request as ready for review August 27, 2024 12:13
SteveYurongSu
SteveYurongSu approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FANTASTIC!!!

@SteveYurongSu SteveYurongSu merged commit 7fe0ff4 into apache:master Aug 28, 2024
25 of 26 checks passed
luoluoyuyu added a commit to luoluoyuyu/iotdb that referenced this pull request Aug 28, 2024
@luoluoyuyu @SteveYurongSu
Pipe: Convert data types when data sync sink metadata does not match …
d8e24c9 
…integration test (apache#13208)

Co-authored-by: Steve Yurong Su <rong@apache.org>
@luoluoyuyu luoluoyuyu deleted the type-conversion-it branch September 2, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveYurongSu SteveYurongSu SteveYurongSu approved these changes

Assignees

@SteveYurongSu SteveYurongSu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luoluoyuyu @SteveYurongSu