Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AliasRelation support #13140

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Add AliasRelation support #13140

merged 1 commit into from
Aug 12, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Aug 12, 2024

Description

Support below sql: select Time,num,bigNum,floatNum,str,bool from table0 t where t.device='d1' order by bigNum,t.time.
Before this pr, this sql will throw error.

Content1 ...

Content2 ...

Content3 ...


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 41.09%. Comparing base (4a3c1d3) to head (7b4c455).
Report is 1 commits behind head on master.

Files Patch % Lines
...engine/plan/relational/planner/TranslationMap.java 0.00% 13 Missing ⚠️
.../relational/planner/ir/ExpressionTreeRewriter.java 0.00% 11 Missing ⚠️
...ngine/plan/relational/planner/RelationPlanner.java 0.00% 10 Missing ⚠️
...plan/relational/planner/ir/ExpressionRewriter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13140      +/-   ##
============================================
- Coverage     41.10%   41.09%   -0.01%     
  Complexity       71       71              
============================================
  Files          3773     3773              
  Lines        233799   233833      +34     
  Branches      28012    28022      +10     
============================================
  Hits          96099    96099              
- Misses       137700   137734      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 3369da8 into master Aug 12, 2024
34 of 35 checks passed
@JackieTien97 JackieTien97 deleted the beyyes/alias branch August 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants