Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe/Subscription: Add LastPointEvent and add LastPointSamplingProcessor #13080

Closed
wants to merge 14 commits into from
Closed

Pipe/Subscription: Add LastPointEvent and add LastPointSamplingProcessor #13080

wants to merge 14 commits into from

Conversation

luoluoyuyu
Copy link
Contributor

Description

as Title

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@luoluoyuyu luoluoyuyu marked this pull request as draft August 1, 2024 14:59
@SteveYurongSu SteveYurongSu self-assigned this Aug 2, 2024
Caideyipi
Caideyipi reviewed Aug 5, 2024
View reviewed changes
...e/src/main/java/org/apache/iotdb/db/pipe/event/common/tsblock/PipeLastPointTsBlockEvent.java Outdated Show resolved Hide resolved
...e/src/main/java/org/apache/iotdb/db/pipe/event/common/tsblock/PipeLastPointTsBlockEvent.java Outdated Show resolved Hide resolved
...e/src/main/java/org/apache/iotdb/db/pipe/event/common/tsblock/PipeLastPointTsBlockEvent.java Outdated Show resolved Hide resolved
...ode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeLastPointTabletEvent.java Outdated Show resolved Hide resolved
...ode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeLastPointTabletEvent.java Outdated Show resolved Hide resolved
...ode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeLastPointTabletEvent.java Outdated Show resolved Hide resolved
@luoluoyuyu luoluoyuyu marked this pull request as ready for review August 5, 2024 10:58
@luoluoyuyu luoluoyuyu changed the title Subscription: Add PipeLastQueryEvent Pipe/Subscription: Add LastPointEvent and add LastPointSamplingProcessor Aug 6, 2024
@luoluoyuyu luoluoyuyu marked this pull request as draft August 8, 2024 10:19
@luoluoyuyu luoluoyuyu marked this pull request as ready for review August 12, 2024 01:56
@luoluoyuyu luoluoyuyu marked this pull request as draft August 12, 2024 02:18
@luoluoyuyu luoluoyuyu closed this Aug 28, 2024
@luoluoyuyu luoluoyuyu deleted the last-query-event branch August 28, 2024 06:26
@luoluoyuyu luoluoyuyu restored the last-query-event branch August 28, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caideyipi Caideyipi Caideyipi left review comments

Assignees

@SteveYurongSu SteveYurongSu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luoluoyuyu @Caideyipi @SteveYurongSu