Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the null handle logic in IDeviceID & like in schema filter & Refactor index scan execution logic #13067

Merged
merged 36 commits into from
Aug 8, 2024
Merged

Correct the null handle logic in IDeviceID & like in schema filter & Refactor index scan execution logic #13067

merged 36 commits into from
Aug 8, 2024

Conversation

Caideyipi
Copy link
Collaborator

Description

As the title said.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Correct the null handle logic in IDeviceID & the partitionKey of deviceID with table Correct the null handle logic in IDeviceID & like in schema filter Jul 31, 2024
@Caideyipi Caideyipi changed the title Correct the null handle logic in IDeviceID & like in schema filter Correct the null handle logic in IDeviceID & like in schema filter & Refactor index scan execution logic Aug 1, 2024
ducstar21
ducstar21 approved these changes Aug 5, 2024
View reviewed changes
Copy link

@ducstar21 ducstar21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug

@JackieTien97 JackieTien97 merged commit e8b114c into apache:ty/TableModelGrammar Aug 8, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackieTien97 JackieTien97 JackieTien97 approved these changes

@ducstar21 ducstar21 ducstar21 approved these changes

@Beyyes Beyyes Awaiting requested review from Beyyes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Caideyipi @JackieTien97 @ducstar21 @jt2594838 @Beyyes