Fixed the classification bug of CheckSchemaPredicateVisitor

apache · Aug 12, 2024 · ef36053 · ef36053
1 parent fb1ce11
commit ef36053
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/...db/queryengine/plan/relational/analyzer/predicate/schema/CheckSchemaPredicateVisitor.java b/...db/queryengine/plan/relational/analyzer/predicate/schema/CheckSchemaPredicateVisitor.java
@@ -42,7 +42,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-// Return whether input expression has an attribute column predicate
+// Return whether input expression can not be bounded to a single ID
 public class CheckSchemaPredicateVisitor
     extends PredicateVisitor<Boolean, CheckSchemaPredicateVisitor.Context> {
 
@@ -79,10 +79,9 @@ protected Boolean visitLogicalExpression(final LogicalExpression node, final Con
             context.queryContext.getSql());
         lastLogTime = System.currentTimeMillis();
       }
-      return false;
+      return true;
     }
-    // TODO: separate or concat expressions, e.g. (id1 or id2 or attr) => (id1 or id2) and (attr)
-    return node.getTerms().stream().allMatch(predicate -> predicate.accept(this, context));
+    return node.getTerms().stream().anyMatch(predicate -> predicate.accept(this, context));
   }
 
   @Override
@@ -94,7 +93,7 @@ protected Boolean visitNotExpression(final NotExpression node, final Context con
             context.queryContext.getSql());
         lastLogTime = System.currentTimeMillis();
       }
-      return false;
+      return true;
     }
     return node.getValue().accept(this, context);
   }