-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#2659: [SonataFlow] Migrate DBMigration Image from SonataFlow operator repository to kie-tools #2697
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments to adjust the PR. Thank you!
|
||
labels: | ||
- name: "org.kie.kogito.version" | ||
value: "999-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value: "999-SNAPSHOT" | |
value: "### SET ME DURING BUILD PROCESS ###" |
set -x | ||
set -e | ||
|
||
useradd -m kogito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ges/kogito-db-migrator-tool/src/main/cekit/modules/kogito-postgres-db-migration-deps/install
Show resolved
Hide resolved
...ogito-db-migrator-tool/src/main/cekit/modules/kogito-postgres-db-migration-deps/migration.sh
Show resolved
Hide resolved
devDeploymentQuarkusApp: { | ||
version: require("../package.json").version, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
-Dversion.quarkus=${env.versions.quarkus} | ||
-Dversion.org.kie.kogito=${env.versions.kogito} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need those here, as they come from maven-base
already.
"build:dev": "./build-db-migrator-jar.sh true", | ||
"build:prod": "./build-db-migrator-jar.sh false", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commands add an unnecessary indirection and don't work on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need so many things here?
DDL_VERSION=10.0.999-SNAPSHOT | ||
DDL_FILE=kogito-ddl-10.0.999-20241018.012042-73-db-scripts.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be parameterized.
{ ignoreDefault: true } // Can't have special <repositories> configuration that only works inside this repo. | ||
); | ||
|
||
installMvnw(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need mvnw
here.
Closes #2659
Add kogito-db-migrator-tool and kogito-db-migrator-tool-image packages for use by the SonataFlow Operator.