kie-issues#1481: Test Scenario Editor: Create @kie-tools/scesim-editor-envelope
#2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomarko
reviewed
Oct 22, 2024
| svg: "", | ||
| }; | ||
| } else { | ||
| throw new Error(`Unknown extension '${ext}'.`); |
There was a problem hiding this comment.
maybe is more unsupported than unknown, or will this new editor has single option - DMN? previously we had DMN and DRL
There was a problem hiding this comment.
@jomarko Only DMN files are directly imported. In case of RULE-based Test Scenario, we don't import the DRL file, but the Java Classes present in the user project.
|
@jomarko Thank you for testing the Extension. Indeed the issue reproduces to me as well, but with new scesim files only. If you open an existing *.scesim file, it works correctly I'll investigate more this behavior when working on apache/incubator-kie-issues#1552 |
tiagobento
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1481
In this PR:
@kie-tools/scesim-editor-envelope, module. The module functionality is still not properly tested. This will be done during Test Scenario Editor: Integrate the@kie-tools/scesim-editorcomponent with the DMN Marshaller incubator-kie-issues#970 and Test Scenario Editor: Update @kie-tools/dmn-vscode-extension to make the new Test Scenario Editor the default one incubator-kie-issues#1552@kie-tools/scesim-editorcomponent with the DMN Marshaller incubator-kie-issues#970