kie-issues#1549: kn-workflow-plugin check for the presence of an image in the local Docker image does not cover all cases #2685
+147
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treblereel
force-pushed
the
apache_issue_1549
branch
4 times, most recently
from
fc3871b
to
efc515a
Compare
…e in the local Docker image does not cover all cases
treblereel
force-pushed
the
apache_issue_1549
branch
from
efc515a
to
d3eb631
Compare
| @@ -51,6 +51,10 @@ type DockerLogMessage struct { | |||
| ID string `json:"id,omitempty"` | |||
| } | |||
|
|
|||
| type DockerClient interface { | |||
| ImageList(ctx context.Context, options types.ImageListOptions) ([]types.ImageSummary, error) | |||
There was a problem hiding this comment.
Does it work for podman too? 🤔
There was a problem hiding this comment.
@ricardozanini you can take a look at func RunContainerCommand at containers.go, only docker uses it.
I plan to refactor it a little in the future, this func can be improved
There was a problem hiding this comment.
oh so this problem won't happen with podman?
There was a problem hiding this comment.
@ricardozanini podman is awesome!
tiagobento
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator-kie-issues#1549