ATLAS-1879 update types again, after updateGraphStore #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
reviewed
Jul 26, 2017
| @@ -381,6 +381,12 @@ public AtlasTypesDef updateTypesDef(AtlasTypesDef typesDef) throws AtlasBaseExce | |||
|
|
|||
| AtlasTypesDef ret = updateGraphStore(typesDef, ttr); | |||
|
|
|||
| try { | |||
| ttr.updateTypesWithNoRefResolve(ret); | |||
There was a problem hiding this comment.
Call updateTypes(), instead of updateTypesWithNoRefResolve() - "*WithNoRefResolve()" calls will not run resolveReferences() hence will leave type objects with no reference to other types (for example: an entity-type will not have its references set for other entity-types references by it).
There was a problem hiding this comment.
@mneethiraj, thanks for your comment, I got you and I fixed that
|
+1 for the patch. Thanks @bpgergo. Since this pull request is on a readonly repo, this can't be merged. Atlas team uses review board (https://reviews.apache.org/) for code review. I would suggest to use review board for patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.