This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
Release 1.2 #23
Open
Release 1.2 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: SimpleRangePartitionFactoryTest relied on old logic for calculating number of partitions and got broken with GIRAPH-1082. Test Plan: Ran the test Differential Revision: https://reviews.facebook.net/D60747
Summary: This test case requires too much memory to run in Jenkins. Talked to Sergey Pupyrev and we decided to disable it. Test Plan: none Reviewers: majakabiljo, maja.kabiljo, spupyrev Reviewed By: spupyrev Differential Revision: https://reviews.facebook.net/D60753
Summary: Need to pass some missing parameters to zookeeper Test Plan: run a few jobs Reviewers: dionysis.logothetis, heslami, majakabiljo, maja.kabiljo Reviewed By: maja.kabiljo Differential Revision: https://reviews.facebook.net/D60831
Summary: On my laptop it failed because of an NPE in WorkerSuperstepMetrics. I tracked it down and found that it is triggered from the branch of code that prints out metrics. We don't normally print out metrics in unit tests, so I'd expect this feature doesn't exist or not functional in hadoop_1. I'll try to disable it, to see how jenkins reacts. Test Plan: mvn test -pl giraph-examples -am -Dtest=TestOutOfCore -DfailIfNoTests=false -Phadoop_1 Reviewers: maja.kabiljo, dionysis.logothetis, heslami Reviewed By: heslami Differential Revision: https://reviews.facebook.net/D60873
Test Plan: This was significantly better in some experiments, but we can investigate more in the future Differential Revision: https://reviews.facebook.net/D62019
Summary: Fixed the list of project committers. Please review your information and let me know if I should change anything. This will be the first diff that I'll be committing all by myself, more like a test to see my username is gone through Apache's internal :-) Test Plan: N/A Reviewers: ikabiljo, pavanka, avery.ching, sergey.edunov Reviewed By: sergey.edunov Differential Revision: https://reviews.facebook.net/D61197
Test Plan: mvn clean verify -Phadoop_facebook Reviewers: majakabiljo, dionysis.logothetis, maja.kabiljo Reviewed By: maja.kabiljo Differential Revision: https://reviews.facebook.net/D60945
Summary: Hadoop_1 and current versions of hbase are incompatible. Removing support for HBASE from Hadoop_1 profile Test Plan: mvn clean package -Phadoop_1 -fae Reviewers: majakabiljo, maja.kabiljo, dionysis.logothetis Reviewed By: maja.kabiljo, dionysis.logothetis Differential Revision: https://reviews.facebook.net/D64197
Summary: Missed that part in the last diff. Test Plan: mvn clean package -Phadoop_2 -fae then checked that giraph-hbase.jar is in the distribution mvn clean package -Phadoop_1 -fae then checked that giraph-hbase.jar is not in the distribution Reviewers: maja.kabiljo, majakabiljo, dionysis.logothetis Reviewed By: dionysis.logothetis Differential Revision: https://reviews.facebook.net/D64203
…ase-1.2 Test Plan: mvn clean verify -Phadoop_facebook mvn clean install -Phadoop_1 mvn clean install -Phadoop_2 Reviewers: majakabiljo, dionysis.logothetis, maja.kabiljo Reviewed By: maja.kabiljo Differential Revision: https://reviews.facebook.net/D64683
…se-1.2 Test Plan: mvn clean verify -Phadoop_facebook rm -rf ~/.m2/repository/org/apache/giraph mvn clean install -Phadoop_1 rm -rf ~/.m2/repository/org/apache/giraph mvn clean install -Phadoop_2 Reviewers: maja.kabiljo, majakabiljo, dionysis.logothetis Reviewed By: dionysis.logothetis Differential Revision: https://reviews.facebook.net/D64719
Test Plan: mvn apache-rat:check -Phadoop_2 mvn apache-rat:check -Phadoop_1 mvn clean verify -Phadoop_facebook Reviewers: maja.kabiljo, majakabiljo, dionysis.logothetis Reviewed By: dionysis.logothetis Differential Revision: https://reviews.facebook.net/D64917
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.