Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #4864] Remove artifacts with incompatible licenses from jdbc-connector #4863

Merged
merged 2 commits into from
May 7, 2024
Merged

[ISSUE #4864] Remove artifacts with incompatible licenses from jdbc-connector #4863

merged 2 commits into from
May 7, 2024

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Apr 24, 2024 •
edited
Loading

This PR is a subtask of #4842

fix #4864

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@mxsm mxsm requested a review from Pil0tXia April 24, 2024 15:30
@Pil0tXia
Copy link
Member

Please be informed that the PR title doesn't correspond to its change.

@mxsm mxsm changed the title [ISSUE #4859] Remove unused variable responseEventMeshCommand in SendSyncMessageProcessor#processRequest (#4860) [ISSUE #4842]Remove artifacts with incompatible licenses from the connector-jdbc classpath(#4860) Apr 24, 2024
@mxsm mxsm changed the title [ISSUE #4842]Remove artifacts with incompatible licenses from the connector-jdbc classpath(#4860) [ISSUE #4842] Remove artifacts with incompatible licenses from the connector-jdbc classpath(#4860) Apr 24, 2024
Pil0tXia
Pil0tXia reviewed Apr 24, 2024
View reviewed changes
eventmesh-connectors/eventmesh-connector-jdbc/build.gradle
Comment on lines 39 to 46
implementation 'com.alibaba:druid:1.2.20'
implementation 'org.hibernate:hibernate-core:5.6.15.Final'
compileOnly 'org.hibernate:hibernate-core:5.6.15.Final'
implementation project(":eventmesh-common")
implementation project(":eventmesh-openconnect:eventmesh-openconnect-java")
implementation project(":eventmesh-spi")
implementation 'com.zendesk:mysql-binlog-connector-java:0.28.0'
implementation 'mysql:mysql-connector-java:8.0.32'
compileOnly 'mysql:mysql-connector-java:8.0.32'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysql-connector-java has been redirected to mysql-connector-j.

Although switching to compileOnly scope, its artifact jar package will still be bundled in our binary distribution. Therefore we will have to remove it manually before releasing, inform users to download its jar package, and put the jar file into the lib directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conversation is a inform and no changes are requested.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I mistook it as runtimeOnly. It do remove artifacts from classpath, and no more manual operation is needed. Users will still have to download and put jar file by themselves.

@mxsm
Copy link
Member Author

mxsm commented Apr 24, 2024

Please be informed that the PR title doesn't correspond to its change.

Please review this PR try again @Pil0tXia

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 24, 2024 •
edited
Loading

Since #4842 contains another artifact xsdlib, may you please create another issue to be closed? I will link this PR as a subtask of #4842~

@mxsm
Copy link
Member Author

mxsm commented Apr 24, 2024

The adjustment no longer requires deletion during packaging, as the package will not be included in the build, as shown in the figure below.
image

@Pil0tXia Pil0tXia changed the title [ISSUE #4842] Remove artifacts with incompatible licenses from the connector-jdbc classpath(#4860) [ISSUE #4842] Remove artifacts with incompatible licenses from jdbc-connector Apr 24, 2024
Pil0tXia
Pil0tXia previously approved these changes Apr 24, 2024
View reviewed changes
@mxsm mxsm changed the title [ISSUE #4842] Remove artifacts with incompatible licenses from jdbc-connector [ISSUE #4864] Remove artifacts with incompatible licenses from jdbc-connector(#4863) Apr 24, 2024
@Pil0tXia Pil0tXia changed the title [ISSUE #4864] Remove artifacts with incompatible licenses from jdbc-connector(#4863) [ISSUE #4864] Remove artifacts with incompatible licenses from jdbc-connector Apr 24, 2024
@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 25, 2024 •
edited
Loading

I just found that ST4 is an incompatible artifact:

image

May you please exclude it from classpath in this PR?

@mxsm mxsm requested a review from Pil0tXia May 6, 2024 01:16
Pil0tXia
Pil0tXia approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia Pil0tXia added the ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder) label May 6, 2024
@xwm1992 xwm1992 merged commit 9d12bc2 into apache:master May 7, 2024
9 checks passed
@mxsm mxsm deleted the en-4842-mxsm branch May 7, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@Pil0tXia Pil0tXia Pil0tXia approved these changes

Assignees
No one assigned
Labels
ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove artifacts with incompatible licenses from jdbc-connector
3 participants
@mxsm @Pil0tXia @xwm1992