Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[opt](index compaction)Add dual write inverted index file switch" #42476

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Oct 25, 2024

Reverts #42280
Due to supporting index compaction for index_v2, we'll optimize this test api later.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@qidaye
Copy link
Contributor Author

qidaye commented Oct 25, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9713/25931)
Line Coverage: 28.72% (80541/280425)
Region Coverage: 28.15% (41649/147961)
Branch Coverage: 24.71% (21159/85642)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fdfe8e503348618adc180ce5ad110f668d8ce789_fdfe8e503348618adc180ce5ad110f668d8ce789/report/index.html

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@qidaye qidaye merged commit 25552e5 into master Oct 25, 2024
32 of 35 checks passed
@qidaye qidaye deleted the revert-42280-index_compaction_test_api branch October 25, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants