Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Use Spark's Logging instead of explicit usage of log4j #84

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Mar 29, 2023

Proposed changes

  • to prevent explicit use of log4j, use Spark's Logging instead
  • Support Spark 3.3.0
    Removed log4j 1.x, and uses Spark's Logging trait, which uses log4j 2.x in Sprak 3.3.0. For older Spark versions , this change does not break the compability. Code changes are in ScalaValueReader.scala

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@bowenliang123 bowenliang123 marked this pull request as draft March 29, 2023 05:25
@bowenliang123
Copy link
Contributor Author

Inspired and cherry-picked from #57 .

cc @JNSimba

@bowenliang123 bowenliang123 marked this pull request as ready for review March 29, 2023 05:29
Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit 1d86a67 into apache:master Mar 31, 2023
@bowenliang123 bowenliang123 deleted the spark-logging branch April 3, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants