Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve]Improve the clarity and detail of the database synchronization logs #467

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

vinlee19
Copy link
Contributor

@vinlee19 vinlee19 commented Aug 9, 2024

Proposed changes

Issue Number: close #xxx

Problem Summary:

When synchronizing hundreds or even thousands of tables from upstream data, if the data types are not supported in Doris, the connector will directly throw an error. However, it might take users a considerable amount of time to identify the problematic tables. Therefore, this pull request adds some log information to assist users in determining the problem.
Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@vinlee19 vinlee19 changed the title [improve]optimize log print [improve]enhance the log print for database synchronization Aug 9, 2024
@vinlee19 vinlee19 changed the title [improve]enhance the log print for database synchronization [improve]Improve the clarity and detail of the database synchronization logs Aug 13, 2024
Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit 63b1290 into apache:master Aug 14, 2024
6 checks passed
vinlee19 added a commit to vinlee19/doris-flink-connector that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants