[improve]Transform the End-To-End(E2E) tasks on the assembly line #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongLiang-0
force-pushed
the
improve-e2e
branch
3 times, most recently
from
ce59eb4
to
137af59
Compare
DongLiang-0
changed the title
JNSimba
reviewed
Aug 15, 2024
...s-connector/src/test/java/org/apache/doris/flink/autoci/container/DorisContainerService.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Aug 15, 2024
...s-connector/src/test/java/org/apache/doris/flink/autoci/container/DorisContainerService.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Aug 15, 2024
JNSimba
reviewed
Aug 15, 2024
Comment on lines
1
to
8
| DROP TABLE IF EXISTS test_e2e_mysql.tbl1; | ||
|
|
||
| CREATE TABLE test_e2e_mysql.tbl1 ( | ||
| `name` varchar(256) primary key, | ||
| `age` int | ||
| ); | ||
|
|
||
| insert into test_e2e_mysql.tbl1 values ('doris_1',1); |
There was a problem hiding this comment.
The table structures are the same, only the table names are different. Do we need to extract them?
There was a problem hiding this comment.
This is the next plan. These cases will be transformed. Each table will have a different structure and will be more complex. Now these cases are too simple.
There was a problem hiding this comment.
For functional testing, can this table structure be reused? And for all types of tests, a single table can be written. I feel that there are too many identical table structures here, which doesn't seem to make much sense?
DongLiang-0
changed the title
JNSimba
reviewed
Aug 16, 2024
flink-doris-connector/src/test/java/org/apache/doris/flink/autoci/AbstractAutoCITestBase.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Aug 16, 2024
...s-connector/src/test/java/org/apache/doris/flink/autoci/container/DorisContainerService.java
Outdated
Show resolved
Hide resolved
DongLiang-0
force-pushed
the
improve-e2e
branch
2 times, most recently
from
050b5ff
to
3558af3
Compare
DongLiang-0
changed the title
DongLiang-0
force-pushed
the
improve-e2e
branch
6 times, most recently
from
31affcf
to
26613bf
Compare
DongLiang-0
force-pushed
the
improve-e2e
branch
from
e7193c4
to
2e76bc4
Compare
JNSimba
reviewed
Sep 3, 2024
...-doris-connector/src/test/java/org/apache/doris/flink/container/instance/MySQLContainer.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Sep 3, 2024
...k-doris-connector/src/test/java/org/apache/doris/flink/container/e2e/Mysql2DorisE2ECase.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Sep 3, 2024
flink-doris-connector/src/test/java/org/apache/doris/flink/container/AbstractE2EService.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Sep 3, 2024
Comment on lines
76
to
91
| public void cancelCurrentJob(String jobName) { | ||
| String currentName = currentJobName.get(); | ||
| Future<?> currentFuture = currentJob.get(); | ||
|
|
||
| if (currentFuture != null && !currentFuture.isDone() && jobName.equals(currentName)) { | ||
| LOG.info("Cancelling the current job. jobName={}", jobName); | ||
| boolean cancelled = currentFuture.cancel(true); | ||
| if (cancelled) { | ||
| LOG.info("Job successfully cancelled. jobName={}", jobName); | ||
| } else { | ||
| LOG.info("Job cancellation failed. jobName={}", jobName); | ||
| } | ||
| } else { | ||
| LOG.info("No matching job to cancel or job already completed. jobName={}", jobName); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need to introduce a thread pool? Why not use Flink's built-in jobClient to cancel?
DongLiang-0
force-pushed
the
improve-e2e
branch
from
8f834ea
to
e599f5e
Compare
DongLiang-0
force-pushed
the
improve-e2e
branch
from
e599f5e
to
71f37d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
The overall code of our early End-To-End tasks was quite confusing. As a result, when we needed to add a simple case, we often needed to add the entire pipeline code. In this way, the readability and scalability of the code are reduced, so we made this transformation.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...