[improve]Improve the hard code in CDC whole database synchronization #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongLiang-0
force-pushed
the
cdc-config
branch
2 times, most recently
from
b76df27
to
0a6bf96
Compare
JNSimba
reviewed
Jul 25, 2024
Comment on lines
+181
to
+187
| case DatabaseSyncConfig.SCAN_STARTUP_MODE_VALUE_INITIAL: | ||
| mongoDBSourceBuilder.startupOptions(StartupOptions.initial()); | ||
| break; | ||
| case LATEST_OFFSET_MODE: | ||
| case DatabaseSyncConfig.SCAN_STARTUP_MODE_VALUE_LATEST_OFFSET: | ||
| mongoDBSourceBuilder.startupOptions(StartupOptions.latest()); | ||
| break; | ||
| case TIMESTAMP_MODE: | ||
| case DatabaseSyncConfig.SCAN_STARTUP_MODE_VALUE_TIMESTAMP: |
There was a problem hiding this comment.
Can we use cdc variables directly here?
There was a problem hiding this comment.
These parameters of flink-cdc cannot be directly referenced because they are also privately defined.
JNSimba
reviewed
Jul 25, 2024
Comment on lines
+51
to
+62
| DEFAULT_PROPS.setProperty(DatabaseSyncConfig.CONVERTERS, DatabaseSyncConfig.DATE); | ||
| DEFAULT_PROPS.setProperty( | ||
| "date.type", "org.apache.doris.flink.tools.cdc.mysql.DateToStringConverter"); | ||
| DEFAULT_PROPS.setProperty("date.format.date", "yyyy-MM-dd"); | ||
| DEFAULT_PROPS.setProperty("date.format.datetime", "yyyy-MM-dd HH:mm:ss.SSSSSS"); | ||
| DEFAULT_PROPS.setProperty("date.format.timestamp", "yyyy-MM-dd HH:mm:ss.SSSSSS"); | ||
| DEFAULT_PROPS.setProperty("date.format.timestamp.zone", "UTC+8"); | ||
| DatabaseSyncConfig.DATE_TYPE, | ||
| "org.apache.doris.flink.tools.cdc.mysql.DateToStringConverter"); | ||
| DEFAULT_PROPS.setProperty( | ||
| DatabaseSyncConfig.DATE_FORMAT_DATE, DatabaseSyncConfig.YEAR_MONTH_DAY_FORMAT); | ||
| DEFAULT_PROPS.setProperty( | ||
| DatabaseSyncConfig.DATE_FORMAT_DATETIME, DatabaseSyncConfig.DATETIME_MICRO_FORMAT); | ||
| DEFAULT_PROPS.setProperty( | ||
| DatabaseSyncConfig.DATE_FORMAT_TIMESTAMP, DatabaseSyncConfig.DATETIME_MICRO_FORMAT); | ||
| DEFAULT_PROPS.setProperty( | ||
| DatabaseSyncConfig.DATE_FORMAT_TIMESTAMP_ZONE, DatabaseSyncConfig.TIME_ZONE_UTC_8); |
There was a problem hiding this comment.
If it is only used here, I think it is better to define it inside this convert class
There was a problem hiding this comment.
Each source corresponds to a DateConverter, which basically contains these parameters.
JNSimba
reviewed
Jul 25, 2024
Comment on lines
+68
to
+86
| props, | ||
| DatabaseSyncConfig.FORMAT_DATE, | ||
| p -> dateFormatter = DateTimeFormatter.ofPattern(p)); | ||
| readProps( | ||
| props, | ||
| "format.timestamp", | ||
| DatabaseSyncConfig.FORMAT_TIME, | ||
| p -> timeFormatter = DateTimeFormatter.ofPattern(p)); | ||
| readProps( | ||
| props, | ||
| DatabaseSyncConfig.FORMAT_DATETIME, | ||
| p -> datetimeFormatter = DateTimeFormatter.ofPattern(p)); | ||
| readProps( | ||
| props, | ||
| DatabaseSyncConfig.FORMAT_TIMESTAMP, | ||
| p -> timestampFormatter = DateTimeFormatter.ofPattern(p)); | ||
| readProps(props, "format.timestamp.zone", z -> timestampZoneId = ZoneId.of(z)); | ||
| readProps( | ||
| props, | ||
| DatabaseSyncConfig.FORMAT_TIMESTAMP_ZONE, | ||
| z -> timestampZoneId = ZoneId.of(z)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
There is a lot of hard code in the code of synchronizing the whole databases. This method can easily lead to inconsistent configurations on both sides. And it brings a very bad experience to subsequent development or code reading.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...