Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] add option ignore commit error #327

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

JNSimba
Copy link
Member

@JNSimba JNSimba commented Mar 4, 2024

Proposed changes

Normally, in 2pc, commit cannot fail, otherwise it will cause data loss.
But sometimes, when resuming a task from checkpoint, the txnid recorded in the checkpoint may have expired. At this time, an error txn not found will be reported, including some other unexpected errors.
At this time, the offset of the source saved by ckpt cannot be used. If the txn is submitted successfully, the first commit failure can be tolerated.

Therefore, the parameter sink.ignore-commit-error is added.
Usually used in 2pc failure recovery, the default is false. If the checkpoint encounters an unrecoverable scenario (such as txn not found), you can temporarily turn on the recovery, and then close the configuration after the checkpoint is normal.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba JNSimba merged commit 182c274 into apache:master Mar 4, 2024
8 checks passed
@JNSimba JNSimba mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants