-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[step2][Improve]Use flink’s checkstyle to format Sink Connector #272
Conversation
...main/java/org/apache/doris/flink/deserialization/DorisJsonDebeziumDeserializationSchema.java
Outdated
Show resolved
Hide resolved
obj.set(mapKey.asText(), mapValue); | ||
obj = JSON_NODE_FACTORY.objectNode(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to code formatting reasons, the actual line 153 corresponds to line 164.
...ris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/RowSerializer.java
Outdated
Show resolved
Hide resolved
...is-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/DateToStringConverter.java
Outdated
Show resolved
Hide resolved
...is-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/DateToStringConverter.java
Outdated
Show resolved
Hide resolved
...-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/MysqlDatabaseSync.java
Outdated
Show resolved
Hide resolved
...oris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDatabaseSync.java
Outdated
Show resolved
Hide resolved
...ris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDateConverter.java
Outdated
Show resolved
Hide resolved
...ris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDateConverter.java
Outdated
Show resolved
Hide resolved
@@ -39,19 +39,23 @@ public class PostgresDateConverter implements CustomConverter<SchemaBuilder, Rel | |||
private DateTimeFormatter dateFormatter = DateTimeFormatter.ISO_DATE; | |||
private DateTimeFormatter timestampFormatter = DateTimeFormatter.ISO_DATE_TIME; | |||
|
|||
public static Properties DEFAULT_PROPS = new Properties(); | |||
public static Properties defaultProps = new Properties(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
...onnector/src/main/java/org/apache/doris/flink/tools/cdc/sqlserver/SqlServerDatabaseSync.java
Outdated
Show resolved
Hide resolved
...nnector/src/main/java/org/apache/doris/flink/tools/cdc/sqlserver/SqlServerDateConverter.java
Outdated
Show resolved
Hide resolved
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/DorisStreamLoad.java
Outdated
Show resolved
Hide resolved
Thanks to @DongLiang-0 , I left some comments, PTAL |
...main/java/org/apache/doris/flink/deserialization/DorisJsonDebeziumDeserializationSchema.java
Show resolved
Hide resolved
...ris-connector/src/main/java/org/apache/doris/flink/table/DorisRowDataJdbcLookupFunction.java
Outdated
Show resolved
Hide resolved
...k-doris-connector/src/main/java/org/apache/doris/flink/table/DorisRowDataLookupFunction.java
Outdated
Show resolved
Hide resolved
...k-doris-connector/src/main/java/org/apache/doris/flink/table/DorisRowDataLookupFunction.java
Outdated
Show resolved
Hide resolved
...k-doris-connector/src/main/java/org/apache/doris/flink/table/DorisRowDataLookupFunction.java
Show resolved
Hide resolved
bdc3f63
to
3b8ca27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Formatting step two, format sink connector.
Related pr: #270
Problem Summary:
In order to format the code more conveniently, we have introduced the
spotless-maven-plugin
plug-in. You can perform code style checking by executingmvn spotless:check
, and format the code by executingmvn spotless:apply
.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...