[step2][Improve]Use flink’s checkstyle to format Sink Connector #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongLiang-0
commented
Dec 14, 2023
JNSimba
reviewed
Dec 14, 2023
...main/java/org/apache/doris/flink/deserialization/DorisJsonDebeziumDeserializationSchema.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
Comment on lines
-155
to
+153
| obj.set(mapKey.asText(), mapValue); | ||
| obj = JSON_NODE_FACTORY.objectNode(); |
There was a problem hiding this comment.
Due to code formatting reasons, the actual line 153 corresponds to line 164.
JNSimba
reviewed
Dec 14, 2023
...ris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/RowSerializer.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
...is-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/DateToStringConverter.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
...is-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/DateToStringConverter.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
...-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/MysqlDatabaseSync.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
...oris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDatabaseSync.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
...ris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDateConverter.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
...ris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDateConverter.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
| @@ -39,19 +39,23 @@ public class PostgresDateConverter implements CustomConverter<SchemaBuilder, Rel | |||
| private DateTimeFormatter dateFormatter = DateTimeFormatter.ISO_DATE; | |||
| private DateTimeFormatter timestampFormatter = DateTimeFormatter.ISO_DATE_TIME; | |||
|
|
|||
| public static Properties DEFAULT_PROPS = new Properties(); | |||
| public static Properties defaultProps = new Properties(); | |||
JNSimba
reviewed
Dec 14, 2023
...onnector/src/main/java/org/apache/doris/flink/tools/cdc/sqlserver/SqlServerDatabaseSync.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
...nnector/src/main/java/org/apache/doris/flink/tools/cdc/sqlserver/SqlServerDateConverter.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/DorisStreamLoad.java
Outdated
Show resolved
Hide resolved
|
Thanks to @DongLiang-0 , I left some comments, PTAL |
DongLiang-0
commented
Dec 15, 2023
...main/java/org/apache/doris/flink/deserialization/DorisJsonDebeziumDeserializationSchema.java
Show resolved
Hide resolved
JNSimba
reviewed
Dec 15, 2023
...ris-connector/src/main/java/org/apache/doris/flink/table/DorisRowDataJdbcLookupFunction.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 15, 2023
...k-doris-connector/src/main/java/org/apache/doris/flink/table/DorisRowDataLookupFunction.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 15, 2023
...k-doris-connector/src/main/java/org/apache/doris/flink/table/DorisRowDataLookupFunction.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 15, 2023
...k-doris-connector/src/main/java/org/apache/doris/flink/table/DorisRowDataLookupFunction.java
Show resolved
Hide resolved
DongLiang-0
force-pushed
the
code-format-sink
branch
from
bdc3f63
to
3b8ca27
Compare
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Formatting step two, format sink connector.
Related pr: #270
Problem Summary:
In order to format the code more conveniently, we have introduced the
spotless-maven-pluginplug-in. You can perform code style checking by executingmvn spotless:check, and format the code by executingmvn spotless:apply.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...